Skip to content

Commit 842fa92

Browse files
authored
Merge pull request #3401 from bluewave-labs/fix/rename-breached-to-exceeded
fix: rename "breached" status to "threshold exceeded"
2 parents 01f2aa2 + 9466090 commit 842fa92

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

client/src/locales/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@
401401
},
402402
"status": {
403403
"down": "down",
404-
"breached": "breached",
404+
"breached": "threshold exceeded",
405405
"initializing": "initializing",
406406
"maintenance": "maintenance",
407407
"paused": "paused",

server/src/service/infrastructure/notificationMessageBuilder.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,9 @@ export class NotificationMessageBuilder implements INotificationMessageBuilder {
145145
}
146146

147147
private buildThresholdBreachContent(monitor: Monitor, monitorStatusResponse: MonitorStatusResponse<HardwareStatusPayload>): NotificationContent {
148-
const title = `Threshold Breach: ${monitor.name}`;
149-
const summary = `Monitor "${monitor.name}" has breached one or more thresholds.`;
150-
const details = [`URL: ${monitor.url}`, `Status: Breached`, `Type: ${monitor.type}`];
148+
const title = `Threshold Exceeded: ${monitor.name}`;
149+
const summary = `Monitor "${monitor.name}" has exceeded one or more thresholds.`;
150+
const details = [`URL: ${monitor.url}`, `Status: Threshold exceeded`, `Type: ${monitor.type}`];
151151

152152
const thresholds = this.extractThresholdBreaches(monitor, monitorStatusResponse);
153153

server/src/service/infrastructure/notificationProviders/email.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export class EmailProvider implements INotificationProvider {
8484
case "monitor_up":
8585
return `Monitor ${message.monitor.name} is back up`;
8686
case "threshold_breach":
87-
return `Monitor ${message.monitor.name} threshold breached`;
87+
return `Monitor ${message.monitor.name} threshold exceeded`;
8888
case "threshold_resolved":
8989
return `Monitor ${message.monitor.name} thresholds resolved`;
9090
default:

0 commit comments

Comments
 (0)