fix: restore isMaintenance field in status page API response#3259
Closed
scrollingreel wants to merge 1 commit intobluewave-labs:developfrom
Closed
fix: restore isMaintenance field in status page API response#3259scrollingreel wants to merge 1 commit intobluewave-labs:developfrom
scrollingreel wants to merge 1 commit intobluewave-labs:developfrom
Conversation
- Changed findByIds to findByIdsWithChecks in statusPageController - Added isMaintenance property to Monitor type - Included isMaintenance in toEntityWithChecks mapping Fixes the regression where isMaintenance was missing in v3.3
scrollingreel
requested review from
Br0wnHammer,
Owaiseimdad,
ajhollid and
karenvicent
as code owners
Br0wnHammer
approved these changes
Feb 9, 2026
Member
Br0wnHammer
left a comment
Br0wnHammer
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix 🚀
Collaborator
|
Thanks for taking a look at this, however the change is intentional. The findByIdsWithChecks aggregation is too slow for use on the status page. Additionally, recent checks are now denormalized and included in the monitor itself, so the old aggregation is no longer needed here. If the maintenance status is required, we'll have to implement a different method of handling that. Please feel free to discuss further in the relevant issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes the regression in v3.3 where
isMaintenancefield was missing from the status page API response (/api/v1/status-page/:url).Root cause: The
getStatusPageByUrlcontroller method was usingfindByIds()which performs a simple query, instead offindByIdsWithChecks()which runs the aggregation pipeline that calculatesisMaintenancefrom maintenance windows.Changes:
findByIdstofindByIdsWithChecksinstatusPageController.tsisMaintenance?: booleanproperty toMonitortypeisMaintenanceintoEntityWithChecksentity mappingWrite your issue number after "Fixes "
Related Issue
Closes #3255