feat: add buffer lookup and location results update to services#3312
Closed
gorkem-bwl wants to merge 1 commit intofeat/globalping-check-modelsfrom
Closed
feat: add buffer lookup and location results update to services#3312gorkem-bwl wants to merge 1 commit intofeat/globalping-check-modelsfrom
gorkem-bwl wants to merge 1 commit intofeat/globalping-check-modelsfrom
Conversation
gorkem-bwl
requested review from
Br0wnHammer,
Owaiseimdad,
ajhollid and
karenvicent
as code owners
gorkem-bwl
force-pushed
the
feat/globalping-check-services
branch
from
f3e251c to
4e7e341
Compare
gorkem-bwl
force-pushed
the
feat/globalping-check-models
branch
2 times, most recently
from
467e0f0 to
ebfcb95
Compare
gorkem-bwl
force-pushed
the
feat/globalping-check-services
branch
from
4e7e341 to
325537e
Compare
## Changes - Add findInBuffer() to BufferService for looking up checks still in the write buffer - Add updateLocationResults() to IChecksRepository interface and MongoChecksRepository - Update GlobalpingService to return GlobalpingCheckResult[] instead of MonitorStatusResponse[] ## Benefits Non-destructive service additions that prepare the backfill pipeline. Existing check-writing and Globalping flows are unchanged.
gorkem-bwl
force-pushed
the
feat/globalping-check-models
branch
from
ebfcb95 to
d25ce9e
Compare
gorkem-bwl
force-pushed
the
feat/globalping-check-services
branch
from
325537e to
3b858de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findInBuffer()to BufferService for looking up checks still in the write buffer by IDupdateLocationResults()to checks repository interface and MongoDB implementationTest plan
npm run buildin/serverpasses with zero errors