feat: add expandable location rows to ChecksTable#3314
Closed
gorkem-bwl wants to merge 1 commit intofeat/globalping-backfill-pipelinefrom
Closed
feat: add expandable location rows to ChecksTable#3314gorkem-bwl wants to merge 1 commit intofeat/globalping-backfill-pipelinefrom
gorkem-bwl wants to merge 1 commit intofeat/globalping-backfill-pipelinefrom
Conversation
gorkem-bwl
requested review from
Br0wnHammer,
Owaiseimdad,
ajhollid and
karenvicent
as code owners
gorkem-bwl
force-pushed
the
feat/globalping-expandable-checks
branch
from
f163077 to
e1cae06
Compare
gorkem-bwl
force-pushed
the
feat/globalping-backfill-pipeline
branch
from
227141c to
0671981
Compare
gorkem-bwl
force-pushed
the
feat/globalping-expandable-checks
branch
from
e1cae06 to
98aa731
Compare
gorkem-bwl
force-pushed
the
feat/globalping-backfill-pipeline
branch
2 times, most recently
from
9052c4f to
de5adf5
Compare
gorkem-bwl
force-pushed
the
feat/globalping-expandable-checks
branch
from
98aa731 to
809d757
Compare
## Changes - Add LocationResult type and locationResults field to client Check type - Add expandable rows to ChecksTable showing per-location Globalping results (location name, status, response time, status code) - Pass globalpingEnabled and locationLabels props from Details page to ChecksTable - Add translation keys for expanded row columns ## Benefits Users can now click a check row to see how each Globalping location performed for that specific monitoring cycle, providing at-a-glance multi-location visibility.
gorkem-bwl
force-pushed
the
feat/globalping-expandable-checks
branch
from
809d757 to
249e109
Compare
gorkem-bwl
force-pushed
the
feat/globalping-backfill-pipeline
branch
from
de5adf5 to
a23e4de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocationResulttype andlocationResultsfield to client Check typeglobalpingEnabledandlocationLabelsfrom the Details page to ChecksTableTest plan
npm run buildin/clientpasses with zero errorsglobalpingEnabledlocationResultsare not expandable