Conversation
Br0wnHammer
left a comment
There was a problem hiding this comment.
LGTM! Just one follow up: If user filters on status:
Up arrow should fetch Up status Pagespeed.
Down arrow should fetch Paused status.
|
@Br0wnHammer is this the desired behavior? we have 3 statuses namely up/down/paused right? and It seems other pages doesn't follow the mentioned pattern of just up/down concept. or am i wrong in assuming this |
|
@akashmannil Up should always filter Up pagespeed. |
|
thanks @Br0wnHammer. but this just means all the pages with the sort needs a fix. sorry if this is a repeat question. since this is no "filter", but a "sort order" by field. Would it be possible to please double check the other pages in develop and let me know if other pages with "sorting" needs a fix as well as per the current mentioned behavior. |
Changes made to fix Pagespeed page sorting by name or status.
Fixes #3330
<div>Add</div>, use):npm run formatin server and client directories, which automatically formats your code.