Skip to content

Pagespeed filter sorting fix#3332

Open
akashmannil wants to merge 1 commit intodevelopfrom
fix/pagespeed-sort
Open

Pagespeed filter sorting fix#3332
akashmannil wants to merge 1 commit intodevelopfrom
fix/pagespeed-sort

Conversation

@akashmannil
Copy link

Changes made to fix Pagespeed page sorting by name or status.

Fixes #3330

image image image image
  • [ x ] (Do not skip this or your PR will be closed) I deployed the application locally.
  • [ x ] (Do not skip this or your PR will be closed) I have performed a self-review and testing of my code.
  • [ x ] I have included the issue # in the PR.
  • [ x ] I have added i18n support to visible strings (instead of <div>Add</div>, use):
const { t } = useTranslation();
<div>{t('add')}</div>
  • [ x ] I have not included any files that are not related to my pull request, including package-lock and package-json if dependencies have not changed
  • [ x ] I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application).
  • [ x ] I made sure font sizes, color choices etc are all referenced from the theme. I don't have any hardcoded dimensions.
  • [ x ] My PR is granular and targeted to one specific feature.
  • [ x ] I ran npm run format in server and client directories, which automatically formats your code.
  • [ x ] I took a screenshot or a video and attached to this PR if there is a UI change.

Copy link
Member

@Br0wnHammer Br0wnHammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one follow up: If user filters on status:
Up arrow should fetch Up status Pagespeed.
Down arrow should fetch Paused status.

@akashmannil
Copy link
Author

@Br0wnHammer is this the desired behavior? we have 3 statuses namely up/down/paused right? and It seems other pages doesn't follow the mentioned pattern of just up/down concept. or am i wrong in assuming this

@Br0wnHammer
Copy link
Member

@akashmannil Up should always filter Up pagespeed.
For down we can have Paused and Down as the pagespeed.

@akashmannil
Copy link
Author

thanks @Br0wnHammer. but this just means all the pages with the sort needs a fix.

sorry if this is a repeat question. since this is no "filter", but a "sort order" by field. Would it be possible to please double check the other pages in develop and let me know if other pages with "sorting" needs a fix as well as per the current mentioned behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pagespeed Page - Sorting by "name" and "status" doesn't work

2 participants