refactor: improve performance; Python 3.11 min#101
Merged
johnfraney merged 6 commits intomainfrom Dec 28, 2024
Merged
Conversation
Improves performance by making better use of concurrency for extracting data from Markdown files and processing images
johnfraney
force-pushed
the
more-performance-improvements
branch
from
ee8c9f7 to
aa0cb33
Compare
Updates the minimum Python version to 3.11 for its built-in tomllib and removes the toml dependency. toml wasn't pickling properly, causing issues with multiprocessing
Changes the non-schema front matter variable prefix from ~ to _ so they don't have to be quoted. tomllib throws an error for an unquoted key starting with "~"
Adds a note to the Markdown docs about non-schema front matter. Also adds a link to the settings file in GitHub to show the default values
johnfraney
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves performance by making better use of concurrency for extracting data from Markdown files and processing images.
Also makes Python 3.11 the minimum required version to fix an issue with
tomlpickling inmultiprocessingand changes theFRONTMATTER_NON_SCHEMA_VARIABLE_PREFIXdefault from~to_, which doesn't need to be quoted and matches PEP 8: https://peps.python.org/pep-0008/#descriptive-naming-styles