Skip to content

Add try/except around all plugin loads #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tbttfox wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add try/except around all plugin loads #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions preditor/plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ def add_logging_handler(self, logger, handler_cls, *args, **kwargs):

def editor(self, name):
for plug_name, ep in self.editors(name):
return plug_name, ep.load()
try:
return plug_name, ep.load()
except Exception:
_logger.warning('Unable to load editor {}'.format(ep.name))
return None, None

def editors(self, name=None):
Expand All @@ -81,7 +84,10 @@ def editors(self, name=None):

def initialize(self, name=None):
for ep in self.iterator(group="preditor.plug.initialize"):
yield ep.load()
try:
yield ep.load()
except Exception:
_logger.warning('Unable to initialize plugin {}'.format(ep.name))

def loggerwindow(self, name=None):
"""Returns instances of "preditor.plug.loggerwindow" plugins.
Expand All @@ -95,11 +101,17 @@ def loggerwindow(self, name=None):
for ep in self.iterator(group="preditor.plug.loggerwindow"):
if name and ep.name != name:
continue
yield ep.name, ep.load()
try:
yield ep.name, ep.load()
except Exception:
_logger.warning('Unable to load plugin {}'.format(ep.name))

def logging_handlers(self, name=None):
for ep in self.iterator(group="preditor.plug.logging_handlers"):
yield ep.name, ep.load()
try:
yield ep.name, ep.load()
except Exception:
_logger.warning('Unable to load handler {}'.format(ep.name))

@classmethod
def iterator(cls, group=None, name=None):
Expand Down