Skip to content

fix: address code review issues from alpha.14 to alpha.15#1068

Merged
bmadcode merged 7 commits intobmad-code-org:mainfrom
alexeyv:fix/alpha15-review-issues
Dec 8, 2025
Merged

fix: address code review issues from alpha.14 to alpha.15#1068
bmadcode merged 7 commits intobmad-code-org:mainfrom
alexeyv:fix/alpha15-review-issues

Conversation

@alexeyv
Copy link
Collaborator

@alexeyv alexeyv commented Dec 8, 2025

Summary

Adversarial code review of changes between v6.0.0-alpha.14 and v6.0.0-alpha.15 identified 10 issues. This PR addresses 8 of them (2 were intentionally ignored as by-design).

Fixed

Ignored (by design)

Test plan

  • npm run test passes (schemas, install, bundles, lint, format)
  • Manual test: fresh install
  • Manual test: quick update on existing installation

@coderabbitai
Copy link

coderabbitai bot commented Dec 8, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@bmadcode bmadcode merged commit cf50f49 into bmad-code-org:main Dec 8, 2025
13 checks passed
bidadh pushed a commit to nextgendev-solutions/BMAD-METHOD-nextgen that referenced this pull request Dec 15, 2025
…org#1068)

* fix: remove debug console.log statements from ui.js

* fix: add error handling and rollback for temp directory cleanup

* fix: use streaming for hash calculation to reduce memory usage

* refactor: hoist CustomHandler require to top of installer.js and ui.js

* fix: fail fast on malformed custom module YAML

User customizations must be valid - silent skip hides broken configs.

* refactor: use consistent return type in handleMissingCustomSources

* refactor: clone config at install() entry to prevent mutation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants