Skip to content

Conversation

@arcaven
Copy link
Contributor

@arcaven arcaven commented Feb 6, 2026

Summary

Remove stale references to validate-workflow.xml which was intentionally removed from the project.

Changes

  • Delete handler-validate-workflow.txt (handler for removed task)
  • Update checklist.md (remove framework references)
  • Update instructions.xml (replace invoke-task with action)
  • Update activation-steps.txt (remove from command list)
  • Update test/README.md (5 command types, not 6)

Context

Issue #1530 reported that validate-workflow.xml was missing. @alexeyv confirmed the file was intentionally removed. This PR cleans up the remaining stale references to prevent confusion.

Closes #1530

The validate-workflow.xml task was intentionally removed, but several
files still referenced it. This cleanup removes all stale references:

- Delete handler-validate-workflow.txt (handler for removed task)
- Update checklist.md (remove framework references)
- Update instructions.xml (replace invoke-task with action)
- Update activation-steps.txt (remove from command list)
- Update test/README.md (5 command types, not 6)

Closes bmad-code-org#1530
@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

This pull request removes the validate-workflow handler infrastructure and replaces it with direct in-line validation in the create-story workflow. References to the missing validate-workflow.xml file are eliminated from configuration, documentation, and workflow definitions.

Changes

Cohort / File(s) Summary
Workflow Definition & Documentation
src/bmm/workflows/4-implementation/create-story/checklist.md, src/bmm/workflows/4-implementation/create-story/instructions.xml
Removed explicit references to validate-workflow.xml framework; consolidated workflow steps and converted <invoke-task> for validation into a direct <action>. Updated checklist guidance to describe workflow-driven process generically.
Handler & Component Configuration
src/utility/agent-components/handler-validate-workflow.txt, src/utility/agent-components/activation-steps.txt
Removed entire validate-workflow handler block; reduced EXECUTE_STEP attributes from 6 to 5 by removing validate-workflow attribute extraction.
Test Documentation
test/README.md
Updated valid menu item command types from six to five, removing validate-workflow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • bmadcode
  • alexeyv
  • pbean
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: remove stale validate-workflow.xml references' directly and concisely describes the main change: removing outdated references to an intentionally deleted file.
Description check ✅ Passed The description clearly explains the purpose (removing stale references), lists the specific files changed, provides context about issue #1530, and explicitly states which issue this closes.
Linked Issues check ✅ Passed The PR directly addresses issue #1530 by removing all stale references to validate-workflow.xml across five files, matching the issue's request to clean up dangling references if the file was intentionally removed.
Out of Scope Changes check ✅ Passed All changes are directly scoped to removing stale validate-workflow.xml references: deleting the handler, updating workflow files, removing from command lists, and updating documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arcaven arcaven marked this pull request as draft February 6, 2026 22:40
@arcaven
Copy link
Contributor Author

arcaven commented Feb 6, 2026

Closing this PR — we jumped the gun on two fronts:

1. No maintainer confirmation on issue #1530
Issue #1530 has zero comments. We assumed the validate-workflow.xml removal was intentional based on issue #1541's closure comment, but #1541 was about a different issue (schema fields, not the missing task file). We should wait for @bmadcode or @alexeyv to confirm whether the file should be restored or references removed.

2. Scope overlap with PR #1567
PR #1567 (workflow.md migration) is the official effort to clean up legacy workflow.xml/yaml references. Our changes to checklist.md and instructions.xml overlap with that migration and could create merge conflicts. Those files should be handled as part of the broader migration, not in a separate cleanup PR.

Will wait for maintainer guidance on #1530 before resubmitting a narrower fix (if needed).

@arcaven arcaven closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question: Is missing core/tasks/validate-workflow.xml returning? — related to #1324, #1351, #1455

1 participant