Skip to content

Conversation

@muratkeremozcan
Copy link
Contributor

Summary

Remove 88% of unused variables from TEA workflow.yaml files (202 → 24 variables) with zero functionality loss.

Problem

Audit revealed systematic variable bloat across all 8 TEA workflows:

  • Boolean flags suggesting configurability but instructions always use best practices
  • Empty placeholders never populated as variables
  • Hardcoded values duplicated between workflow.yaml and instructions.md

Bloat by workflow:

  • framework: 14 → 4 (71% reduction)
  • ci: 28 → 2 (93% reduction)
  • test-design: 20 → 1 (95% reduction)
  • atdd: 20 → 1 (95% reduction)
  • automate: 34 → 4 (88% reduction)
  • trace: 52 → 5 (90% reduction)
  • nfr-assess: 30 → 1 (97% reduction)
  • test-review: 24 → 2 (92% reduction)

Solution

Removed unused variables while preserving:

  • ✅ All instructions.md files (6,056 lines) - unchanged
  • ✅ All knowledge fragments (21 files, 12,821 lines) - unchanged
  • ✅ Markdown v4.0 format - unchanged
  • ✅ MCP integration (config.tea_use_mcp_enhancements) - intact
  • ✅ Dual-mode capability (standalone_mode in automate) - preserved
  • ✅ trace+gate merger - preserved
  • ✅ All templates, READMEs, checklists - unchanged

Changes

Modified: 8 workflow.yaml files only
Added: 0 files
Deleted: ~400 lines of bloat
Functionality: Identical (instructions never used removed variables)

Testing

  • MCP integration verified (config file + instructions.md intact)
  • Dual-mode preserved (standalone_mode in automate workflow)
  • Essential variables preserved (user choices, paths, modes)
  • Instructions.md unchanged (no behavior changes)

Impact

Before: 202 variables across 8 workflows (50-90% bloat per workflow)
After: 24 essential variables (0% bloat)

Maintainability: Significantly improved - clear what's actually configurable
Compliance: Now BMad v6 compliant (lean variable principle)
Functionality: Zero loss - instructions handle everything

Context

See audit documentation:

  • testarch-file-review/CONSOLIDATED-AUDIT-FINDINGS.md
  • testarch-file-review/CLEANUP-SUMMARY.md
  • `TEA-AUDIT-WORKFLOW-PLAN.md

@bmadcode bmadcode merged commit 84a70d8 into v6-alpha Oct 17, 2025
3 checks passed
davedittrich pushed a commit to davedittrich/BMAD-METHOD that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants