fix: correct retrospective workflow handoff#770
fix: correct retrospective workflow handoff#770bmadcode merged 1 commit intobmad-code-org:v6-alphafrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Align retrospective ownership to the Scrum Master across workflows and guidance, matching documented process.
- Switch retrospective step agent from pm to sm in multiple workflow-status paths
- Update story-approved instructions to direct users to run the retrospective with the SM agent
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/bmm/workflows/workflow-status/paths/greenfield-level-4.yaml | Set retrospective step agent to sm for epic completion |
| src/modules/bmm/workflows/workflow-status/paths/greenfield-level-3.yaml | Set retrospective step agent to sm for epic completion |
| src/modules/bmm/workflows/workflow-status/paths/greenfield-level-2.yaml | Set retrospective step agent to sm for epic completion |
| src/modules/bmm/workflows/workflow-status/paths/game-design.yaml | Set retrospective step agent to sm for retrospective in feature flow |
| src/modules/bmm/workflows/workflow-status/paths/brownfield-level-4.yaml | Set retrospective step agent to sm for epic completion |
| src/modules/bmm/workflows/workflow-status/paths/brownfield-level-3.yaml | Set retrospective step agent to sm for epic completion |
| src/modules/bmm/workflows/4-implementation/story-approved/instructions.md | Update next-step guidance to use SM agent for retrospective |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| **Next Steps:** | ||
|
|
||
| 1. Run `retrospective` workflow with PM agent to review the project | ||
| 1. Run `retrospective` workflow with SM agent to review the project |
There was a problem hiding this comment.
[nitpick] Consider expanding the acronym for clarity: 'Run retrospective workflow with Scrum Master (SM) agent to review the project' to make this instruction self-explanatory for new contributors.
| 1. Run `retrospective` workflow with SM agent to review the project | |
| 1. Run `retrospective` workflow with Scrum Master (SM) agent to review the project |
| epic_completion: | ||
| - id: "retrospective" | ||
| recommended: true | ||
| agent: "pm" | ||
| agent: "sm" | ||
| command: "retrospective" | ||
|
|
There was a problem hiding this comment.
[nitpick] The retrospective step definition is duplicated across multiple path files. Consider extracting a shared YAML anchor or central include for the epic_completion.retrospective step (with agent: 'sm') to keep all paths consistent and reduce future drift.
|
I have reviewed and tested this. Looks good.
|
|
@Jrakru thank you! |
|
Thanks for catching this @Jrakru ! |
Summary
Testing