Fix broken pipeline by updating outdated steps

.github/workflows/continuous-integration.yml

@@ -114,9 +114,9 @@ jobs:
           docker run -i --rm -v $PWD:/churn ${{ matrix.vcs }} /churn/vendor/bin/simple-phpunit -c /churn/phpunit.xml.dist /churn/tests/EndToEnd/${vcs^}Test.php --coverage-clover=/churn/coverage-${{ matrix.vcs }}.xml
           sed -i 's/\/churn\/src/\/home\/runner\/work\/${{ github.event.repository.name }}\/${{ github.event.repository.name }}\/src/g' coverage-${{ matrix.vcs }}.xml
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
-          name: coverage
+          name: coverage-${{ matrix.vcs }}
           path: ./coverage-${{ matrix.vcs }}.xml
 
   coverage:
@@ -146,9 +146,10 @@ jobs:
         run: "vendor/bin/simple-phpunit --colors=always --testdox --testsuite churn-tests --coverage-clover=coverage.xml"
 
       - name: "Download other code coverage reports"
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          name: coverage
+          pattern: coverage-*
+          merge-multiple: true
           path: ./coverage
 
       - name: "List all coverage reports"
@@ -269,7 +270,7 @@ jobs:
         run: diff -u <(build/bin/churn --format=csv | sort) <(./churn.phar --format=csv | sort)
 
       - name: "Save Phar"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: churn.phar
           path: ./churn.phar
@@ -300,7 +301,7 @@ jobs:
           tools: none
 
       - name: Download churn.phar
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: churn.phar
 
@@ -342,7 +343,7 @@ jobs:
           tools: none
 
       - name: Download churn.phar
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: churn.phar
 

.github/workflows/pull-request.yml

@@ -20,10 +20,10 @@ jobs:
         with:
           coverage: "pcov"
           ini-values: "error_reporting=-1, display_errors=On, display_startup_errors=On, zend.assertions=1"
-          php-version: "8.1"
+          php-version: "8.2"
           tools: composer:v2, infection
 
-      - uses: "ramsey/composer-install@v2"
+      - uses: "ramsey/composer-install@v3"
         with:
           dependency-versions: "highest"
           composer-options: "--no-scripts"

phpcs-tests.xml

@@ -65,5 +65,10 @@
     <exclude name="Squiz.Commenting.FunctionComment.SpacingAfterParamName"/>
     <exclude name="Squiz.Commenting.FunctionComment.SpacingAfterParamType"/>
   </rule>
+  <rule ref="SlevomatCodingStandard.Attributes.AttributesOrder">
+    <properties>
+      <property name="orderAlphabetically" value="true" />
+    </properties>
+  </rule>
   <rule ref="vendor-bin/phpcs/vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/Formatting/SpaceAfterCastSniff.php"/>
 </ruleset>

phpcs.xml

@@ -59,6 +59,11 @@
     <exclude name="Squiz.Commenting.FunctionComment.SpacingAfterParamName"/>
     <exclude name="Squiz.Commenting.FunctionComment.SpacingAfterParamType"/>
   </rule>
+  <rule ref="SlevomatCodingStandard.Attributes.AttributesOrder">
+    <properties>
+      <property name="orderAlphabetically" value="true" />
+    </properties>
+  </rule>
   <rule ref="vendor-bin/phpcs/vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/Formatting/SpaceAfterCastSniff.php"/>
 
   <!-- Codor rules -->

phpunit.xml.dist

@@ -25,6 +25,5 @@
     </coverage>
     <php>
         <env name="SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT" value="1" />
-        <env name="SYMFONY_PHPUNIT_REQUIRE" value="nikic/php-parser:^4.19"/>
     </php>
 </phpunit>

psalm.xml

@@ -17,6 +17,7 @@
         <directory name="tests"/>
         <ignoreFiles>
             <file name="tests/console-application.php"/>
+            <directory name="tests/**/Assets*"/>
         </ignoreFiles>
     </projectFiles>
 

src/Assessor/CyclomaticComplexityAssessor.php

@@ -43,6 +43,7 @@ public function __construct()
      *
      * @param string $contents The contents of a PHP file.
      */
+    #[\Override]
     public function assess(string $contents): int
     {
         $score = 0;

src/Command/AssessComplexityCommand.php

@@ -44,6 +44,7 @@ public static function newInstance(): self
     /**
      * Configure the command
      */
+    #[\Override]
     protected function configure(): void
     {
         $this->setName('assess-complexity')
@@ -57,6 +58,7 @@ protected function configure(): void
      * @param InputInterface $input Input.
      * @param OutputInterface $output Output.
      */
+    #[\Override]
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $file = (string) $input->getArgument('file');

src/Command/Helper/ProgressBarSubscriber.php

@@ -34,6 +34,7 @@ public function __construct(OutputInterface $output)
     /**
      * @param AfterAnalysisEvent $event The event triggered when the analysis is done.
      */
+    #[\Override]
     public function onAfterAnalysis(AfterAnalysisEvent $event): void
     {
         $this->progressBar->finish();
@@ -42,6 +43,7 @@ public function onAfterAnalysis(AfterAnalysisEvent $event): void
     /**
      * @param BeforeAnalysisEvent $event The event triggered when the analysis starts.
      */
+    #[\Override]
     public function onBeforeAnalysis(BeforeAnalysisEvent $event): void
     {
         $this->progressBar->start();
@@ -50,6 +52,7 @@ public function onBeforeAnalysis(BeforeAnalysisEvent $event): void
     /**
      * @param AfterFileAnalysisEvent $event The event triggered when the analysis of a file is done.
      */
+    #[\Override]
     public function onAfterFileAnalysis(AfterFileAnalysisEvent $event): void
     {
         $this->progressBar->advance();

src/Command/RunCommand.php

@@ -84,6 +84,7 @@ public static function newInstance(): self
     /**
      * Configure the command
      */
+    #[\Override]
     protected function configure(): void
     {
         $this->setName('run')
@@ -104,6 +105,7 @@ protected function configure(): void
      * @param InputInterface $input Input.
      * @param OutputInterface $output Output.
      */
+    #[\Override]
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         if (true === $input->getOption('quiet')) {

src/Configuration/Validator/BaseValidator.php

@@ -34,6 +34,7 @@ public function __construct(string $key)
     /**
      * Returns the configuration key.
      */
+    #[\Override]
     public function getKey(): string
     {
         return $this->key;
@@ -43,6 +44,7 @@ public function getKey(): string
      * @param EditableConfig $config The configuration object.
      * @param array<mixed> $configuration The array containing the configuration values.
      */
+    #[\Override]
     public function validate(EditableConfig $config, array $configuration): void
     {
         if (!\array_key_exists($this->key, $configuration)) {

src/Configuration/Validator/CachePath.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         if (null === $value) {

src/Configuration/Validator/CommitsSince.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param array<mixed> $configuration The array containing the configuration values.
      */
+    #[\Override]
     public function validate(EditableConfig $config, array $configuration): void
     {
         if (!$this->hasConfigurationKey($configuration)) {
@@ -40,6 +41,7 @@ public function validate(EditableConfig $config, array $configuration): void
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         Assert::string($value, 'Commits since should be a string');

src/Configuration/Validator/DirectoriesToScan.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         Assert::isArray($value, 'Directories to scan should be an array of strings');

src/Configuration/Validator/FileExtensions.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         Assert::isArray($value, 'File extensions should be an array of strings');

src/Configuration/Validator/FilesToIgnore.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         Assert::isArray($value, 'Files to ignore should be an array of strings');

src/Configuration/Validator/FilesToShow.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         Assert::integer($value, 'Files to show should be an integer');

src/Configuration/Validator/Hooks.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         Assert::isArray($value, 'Hooks should be an array of strings');

src/Configuration/Validator/MaxScoreThreshold.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         if (null === $value) {

src/Configuration/Validator/MinScoreToShow.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         if (null === $value) {

src/Configuration/Validator/ParallelJobs.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         Assert::integer($value, 'Amount of parallel jobs should be an integer');

src/Configuration/Validator/Vcs.php

@@ -24,6 +24,7 @@ public function __construct()
      * @param EditableConfig $config The configuration object.
      * @param mixed $value The value to validate.
      */
+    #[\Override]
     protected function validateValue(EditableConfig $config, $value): void
     {
         Assert::string($value, 'VCS should be a string');

src/Event/BrokerImpl.php

@@ -39,6 +39,7 @@ public function __construct()
     /**
      * @param object $subscriber A subscriber object.
      */
+    #[\Override]
     public function subscribe($subscriber): void
     {
         foreach ($this->channels as $channel) {
@@ -53,6 +54,7 @@ public function subscribe($subscriber): void
     /**
      * @param Event $event The triggered event.
      */
+    #[\Override]
     public function notify(Event $event): void
     {
         foreach ($this->subscribers as $eventClass => $subscribers) {

src/Event/Channel/AfterAnalysisChannel.php

@@ -18,6 +18,7 @@ final class AfterAnalysisChannel implements Channel
     /**
      * @param object $subscriber A subscriber instance.
      */
+    #[\Override]
     public function accepts($subscriber): bool
     {
         return $subscriber instanceof AfterAnalysis;
@@ -26,6 +27,7 @@ public function accepts($subscriber): bool
     /**
      * @psalm-return class-string<AfterAnalysisEvent>
      */
+    #[\Override]
     public function getEventClassname(): string
     {
         return AfterAnalysisEvent::class;
@@ -36,6 +38,7 @@ public function getEventClassname(): string
      * @psalm-param AfterAnalysis $subscriber
      * @psalm-return Closure(AfterAnalysisEvent): void
      */
+    #[\Override]
     public function buildEventHandler($subscriber): Closure
     {
         return static function (AfterAnalysisEvent $event) use ($subscriber): void {

src/Event/Channel/AfterFileAnalysisChannel.php

@@ -18,6 +18,7 @@ final class AfterFileAnalysisChannel implements Channel
     /**
      * @param object $subscriber A subscriber instance.
      */
+    #[\Override]
     public function accepts($subscriber): bool
     {
         return $subscriber instanceof AfterFileAnalysis;
@@ -26,6 +27,7 @@ public function accepts($subscriber): bool
     /**
      * @psalm-return class-string<AfterFileAnalysisEvent>
      */
+    #[\Override]
     public function getEventClassname(): string
     {
         return AfterFileAnalysisEvent::class;
@@ -36,6 +38,7 @@ public function getEventClassname(): string
      * @psalm-param AfterFileAnalysis $subscriber
      * @psalm-return Closure(AfterFileAnalysisEvent): void
      */
+    #[\Override]
     public function buildEventHandler($subscriber): Closure
     {
         return static function (AfterFileAnalysisEvent $event) use ($subscriber): void {

src/Event/Channel/BeforeAnalysisChannel.php

@@ -18,6 +18,7 @@ final class BeforeAnalysisChannel implements Channel
     /**
      * @param object $subscriber A subscriber instance.
      */
+    #[\Override]
     public function accepts($subscriber): bool
     {
         return $subscriber instanceof BeforeAnalysis;
@@ -26,6 +27,7 @@ public function accepts($subscriber): bool
     /**
      * @psalm-return class-string<BeforeAnalysisEvent>
      */
+    #[\Override]
     public function getEventClassname(): string
     {
         return BeforeAnalysisEvent::class;
@@ -36,6 +38,7 @@ public function getEventClassname(): string
      * @psalm-param BeforeAnalysis $subscriber
      * @psalm-return Closure(BeforeAnalysisEvent): void
      */
+    #[\Override]
     public function buildEventHandler($subscriber): Closure
     {
         return static function (BeforeAnalysisEvent $event) use ($subscriber): void {

src/Event/Event/AfterAnalysisEvent.php

@@ -27,6 +27,7 @@ public function __construct(ResultReporter $resultReporter)
     /**
      * Returns the total number of files analysed.
      */
+    #[\Override]
     public function getNumberOfFiles(): int
     {
         return $this->resultReporter->getNumberOfFiles();
@@ -35,6 +36,7 @@ public function getNumberOfFiles(): int
     /**
      * Returns the max number of changes among the analysed files.
      */
+    #[\Override]
     public function getMaxNumberOfChanges(): int
     {
         return $this->resultReporter->getMaxCommits();
@@ -43,6 +45,7 @@ public function getMaxNumberOfChanges(): int
     /**
      * Returns the max cyclomatic complexity among the analysed files.
      */
+    #[\Override]
     public function getMaxCyclomaticComplexity(): int
     {
         return $this->resultReporter->getMaxComplexity();
@@ -51,6 +54,7 @@ public function getMaxCyclomaticComplexity(): int
     /**
      * Returns the highest score among the analysed files.
      */
+    #[\Override]
     public function getMaxScore(): ?float
     {
         return $this->resultReporter->getMaxScore();