port of p5.collide2d to Processing#15
Open
jacobjoaquin wants to merge 3 commits intobmoren:masterfrom
jacobjoaquin:first-pass
Open
port of p5.collide2d to Processing#15jacobjoaquin wants to merge 3 commits intobmoren:masterfrom jacobjoaquin:first-pass
jacobjoaquin wants to merge 3 commits intobmoren:masterfrom
jacobjoaquin:first-pass
Conversation
Contributor
|
I would change the title of you pull request to your description Question how much of the lib is implemented? |
Owner
|
Hi @jacobjoaquin not sure if you're still working on this, but since p5.js and processing are so different in structure and how libraries get used, I'd suggest you move this branch into it's own project for Processing. I think this will make things clearer for users and help with getting the library available in the Processing library manager. I'm going to leave this PR open and pending for anyone who happens to stumble across this until you create a separate project that I can link to in the p5 version's readme file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick port of p5.collide2d into Collide2d.pde inside of /dev/DevCollide2d.