Extend bazel rule for trlc #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melodyoncode
commented
Aug 21, 2025
melodyoncode
commented
- the stakeholder requirements could be listed as dependency
- add trlc_specification_test
castler
requested changes
Aug 21, 2025
trlc.bzl
Outdated
| attrs = { | ||
| "srcs": attr.label_list(allow_files = [".trlc"]), | ||
| "spec": attr.label_list(allow_empty = False, providers = [DefaultInfo]), | ||
| "dep_reqs": attr.label_list(allow_files = False, allow_empty = True, providers = [TrlcProviderInfo]), |
Contributor
There was a problem hiding this comment.
Can we call this please just deps, this way we are consistent to other well known bazel rules
melodyoncode
force-pushed
the
extend_bazel_rule_for_reqs
branch
from
96746c0 to
20707fa
Compare
castler
approved these changes
Aug 21, 2025
phiwuu
approved these changes
Sep 22, 2025
- the stakeholder requirements could be listed as dependency - add trlc_specification_test
phiwuu
force-pushed
the
extend_bazel_rule_for_reqs
branch
from
20707fa to
74fd94c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.