fix: correct order number gender logic and add null order tests#20
Merged
fix: correct order number gender logic and add null order tests#20
Conversation
Owner
bn3t
commented
Jan 12, 2026
- Fix bug where order numbers were inverted for gender: males were getting even numbers and females odd numbers, should be odd for males and even for females
- Add test for generating valid SSIN when order is null
- Add test verifying males get odd order numbers
- Add test verifying females get even order numbers
- Fix bug where order numbers were inverted for gender: males were getting even numbers and females odd numbers, should be odd for males and even for females - Add test for generating valid SSIN when order is null - Add test verifying males get odd order numbers - Add test verifying females get even order numbers
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the SSIN (Social Security Identification Number) generator where gender-based order number assignment was inverted. The fix ensures males receive odd order numbers and females receive even order numbers, as required by the SSIN specification.
Changes:
- Corrected the gender logic in
generateStringOrderNumberto assign odd numbers to males and even numbers to females - Added comprehensive test coverage for null order parameter scenarios
- Added specific tests to verify correct gender-based order number generation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/SSINGeneratorHelper.ts | Fixed inverted gender logic: changed condition from Gender.MALE decrement to Gender.FEMALE increment, ensuring males get odd and females get even order numbers |
| src/lib/SSINGeneratorHelper.test.ts | Added three new tests: validates SSIN generation with null order, verifies males receive odd order numbers, and verifies females receive even order numbers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.