Skip to content

fix: correct order number gender logic and add null order tests#20

Merged
bn3t merged 2 commits intomainfrom
fix/order-number-generation
Jan 12, 2026
Merged

fix: correct order number gender logic and add null order tests#20
bn3t merged 2 commits intomainfrom
fix/order-number-generation

Conversation

@bn3t
Copy link
Owner

@bn3t bn3t commented Jan 12, 2026

  • Fix bug where order numbers were inverted for gender: males were getting even numbers and females odd numbers, should be odd for males and even for females
  • Add test for generating valid SSIN when order is null
  • Add test verifying males get odd order numbers
  • Add test verifying females get even order numbers

- Fix bug where order numbers were inverted for gender:
  males were getting even numbers and females odd numbers,
  should be odd for males and even for females
- Add test for generating valid SSIN when order is null
- Add test verifying males get odd order numbers
- Add test verifying females get even order numbers
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug in the SSIN (Social Security Identification Number) generator where gender-based order number assignment was inverted. The fix ensures males receive odd order numbers and females receive even order numbers, as required by the SSIN specification.

Changes:

  • Corrected the gender logic in generateStringOrderNumber to assign odd numbers to males and even numbers to females
  • Added comprehensive test coverage for null order parameter scenarios
  • Added specific tests to verify correct gender-based order number generation

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/lib/SSINGeneratorHelper.ts Fixed inverted gender logic: changed condition from Gender.MALE decrement to Gender.FEMALE increment, ensuring males get odd and females get even order numbers
src/lib/SSINGeneratorHelper.test.ts Added three new tests: validates SSIN generation with null order, verifies males receive odd order numbers, and verifies females receive even order numbers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bn3t bn3t merged commit b0109ad into main Jan 12, 2026
4 checks passed
@bn3t bn3t deleted the fix/order-number-generation branch January 12, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant