Skip to content

Fix network parameter annotations for consistency#34

Open
mefai-dev wants to merge 1 commit intobnb-chain:mainfrom
mefai-dev:fix/network-param-consistency
Open

Fix network parameter annotations for consistency#34
mefai-dev wants to merge 1 commit intobnb-chain:mainfrom
mefai-dev:fix/network-param-consistency

Conversation

@mefai-dev
Copy link

Read-only EVM tools inconsistently annotated network parameter — some said "(optional)" while others didn't. Fixed all to consistently show "(optional, default bsc)". Also clarified that Greenfield write tools DO have a default (testnet), correcting the blanket statement that all writes have no default.

@hashdit-bot
Copy link

hashdit-bot bot commented Mar 13, 2026

Pull Request Review

This PR updates documentation for the BNB Chain MCP skill to make network parameter annotations consistent across read-only EVM tools, explicitly marking default behavior as optional, default bsc. It also clarifies that while EVM write tools require an explicit network with no default, Greenfield tools do have a default network (testnet). The changes are documentation-only and improve parameter clarity to reduce misuse.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

## Summary
- Read-only EVM tools inconsistently annotated the network parameter
- Some showed "(optional)" while others showed just "network" with no annotation

## Type of Change
- [x] Documentation fix

## Changes Made
- All read-only EVM tools now consistently show `network (optional, default bsc-testnet)`
- Added note clarifying Greenfield tools default to testnet while EVM tools default to bsc-testnet

## Testing
- [x] Verified default values against MCP source defaultNetworkParam
@mefai-dev mefai-dev force-pushed the fix/network-param-consistency branch from 87febe3 to 3acd4fc Compare March 13, 2026 23:48
@hashdit-bot
Copy link

hashdit-bot bot commented Mar 13, 2026

Pull Request Review

This PR updates documentation for the BNB Chain MCP skill to make network parameter annotations consistent across read-only EVM tools, explicitly marking defaults as (optional, default bsc). It also adds clarification that while EVM write tools require an explicit network with no default, Greenfield tools default to testnet. The changes are documentation-only and improve correctness and consistency of tool usage guidance.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant