Skip to content

Replace vague parameter descriptions with actual parameter names in G…#37

Open
mefai-dev wants to merge 1 commit intobnb-chain:mainfrom
mefai-dev:fix/greenfield-vague-params
Open

Replace vague parameter descriptions with actual parameter names in G…#37
mefai-dev wants to merge 1 commit intobnb-chain:mainfrom
mefai-dev:fix/greenfield-vague-params

Conversation

@mefai-dev
Copy link

…reenfield reference

Summary

  • Replaced "address/privateKey as per implementation" with actual parameter names and required/optional annotations
  • Replaced "account identifier (see implementation)" with paymentAddress (required)
  • Added default value for folderName parameter

Type of Change

  • Documentation fix

Changes Made

  • gnfd_get_account_balance: vague params → address (optional), privateKey (required, defaults to env PRIVATE_KEY)
  • gnfd_get_payment_account_info: "see implementation" → paymentAddress (required)
  • gnfd_create_folder: added default value documentation

Testing

  • Cross-referenced against bnbchain-mcp source code

@hashdit-bot
Copy link

hashdit-bot bot commented Mar 13, 2026

Pull Request Review

This PR is a documentation-only update to the Greenfield tools reference, replacing ambiguous parameter descriptions with explicit parameter names and required/optional annotations. It clarifies gnfd_get_account_balance and gnfd_get_payment_account_info inputs, and documents a default value for folderName in gnfd_create_folder. Overall, the changes improve usability and reduce confusion when mapping docs to actual MCP tool signatures.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

…reenfield reference

## Summary
- Multiple Greenfield tools used "see implementation" or "account identifier" instead of actual parameter names
- This makes tool calls impossible without reading the MCP source code

## Type of Change
- [x] Documentation fix

## Changes Made
- gnfd_get_account_balance: "address/privateKey as per implementation" → `address (optional), privateKey (required, defaults to env PRIVATE_KEY)`
- gnfd_get_payment_account_info: "account identifier (see implementation)" → `paymentAddress (required)`
- gnfd_create_folder: added default value `created-by-bnbchain-mcp` for folderName

## Testing
- [x] Verified parameter names against MCP source code
@mefai-dev mefai-dev force-pushed the fix/greenfield-vague-params branch from f319ed3 to 627770f Compare March 13, 2026 23:49
@hashdit-bot
Copy link

hashdit-bot bot commented Mar 13, 2026

Pull Request Review

This PR is a documentation-only update to the Greenfield tools reference, replacing ambiguous parameter descriptions with explicit parameter names and required/optional annotations. It clarifies gnfd_get_account_balance and gnfd_get_payment_account_info inputs and adds a documented default value for folderName in gnfd_create_folder. No executable code or runtime logic changes are introduced.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant