Skip to content

Fix args required/optional annotations for contract tools#40

Open
mefai-dev wants to merge 1 commit intobnb-chain:mainfrom
mefai-dev:fix/contract-args-annotation
Open

Fix args required/optional annotations for contract tools#40
mefai-dev wants to merge 1 commit intobnb-chain:mainfrom
mefai-dev:fix/contract-args-annotation

Conversation

@mefai-dev
Copy link

Summary

  • Fixed read_contract args marked as required when they're optional
  • Fixed write_contract args not explicitly marked as required
  • Improved ABI description clarity

Type of Change

  • Documentation fix

Changes Made

  • read_contract: args → "args (optional array)"
  • write_contract: args → "args (required array)"
  • Clarified ABI format: full contract ABI or relevant function entries

@hashdit-bot
Copy link

hashdit-bot bot commented Mar 13, 2026

Pull Request Review

This PR updates documentation for the EVM contract tools reference, specifically clarifying required vs optional args parameters for read_contract and write_contract. It also improves the ABI parameter descriptions by specifying that ABI should be a JSON array of entries and can be full contract ABI or relevant function entries. Overall, the changes are documentation-only and improve correctness/clarity for tool usage.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

## Summary
- read_contract and write_contract both showed "args" without indicating required vs optional
- In the MCP source, read_contract args are optional but write_contract args are required

## Type of Change
- [x] Documentation fix

## Changes Made
- read_contract: args → "args (optional array)"
- write_contract: args → "args (required array)"
- Improved ABI description: "Pass the contract ABI (full or relevant function entries)"

## Testing
- [x] Verified against MCP source zod schemas
@mefai-dev mefai-dev force-pushed the fix/contract-args-annotation branch from 3421a26 to e99f057 Compare March 13, 2026 23:49
@hashdit-bot
Copy link

hashdit-bot bot commented Mar 13, 2026

Pull Request Review

This PR updates documentation for EVM contract tools in evm-tools-reference.md, mainly clarifying parameter requirements for read_contract and write_contract. It explicitly marks args as optional for read_contract and required for write_contract, and improves ABI guidance by stating that full ABI or relevant function entries are acceptable. Overall, this is a documentation-only consistency and clarity fix with no code logic changes.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant