Skip to content

Fix wallet tool parameter annotations#54

Open
mefai-dev wants to merge 24 commits intobnb-chain:mainfrom
mefai-dev:fix/evm-wallet-param-annotations
Open

Fix wallet tool parameter annotations#54
mefai-dev wants to merge 24 commits intobnb-chain:mainfrom
mefai-dev:fix/evm-wallet-param-annotations

Conversation

@mefai-dev
Copy link

Summary

  • Balance/transfer tools lacked annotations

Type of Change

  • Documentation fix

Changes Made

  • address: required for get_erc20_balance
  • ENS support note for transfers

Testing

  • Verified against MCP source

mefai-dev and others added 24 commits March 9, 2026 00:12
- Professional README with architecture docs and API reference
- Self-contained FastAPI backend (api/)
- Vanilla JS frontend with 50 Web Components (frontend/)
- Contribution guide and code ownership
- Updated bnbchain-mcp-skill references

Built by Mefai for the BNB Chain community.
Skills:
- honeypot-check: Combined honeypot detection with bytecode analysis, buy/sell ratio, and owner concentration scoring
- contract-xray: Deep bytecode analysis with proxy detection, function scanning, and mint/pause/blacklist pattern recognition
- approval-scanner: Token approval checker across 9 major DEX routers with unlimited allowance detection
- risk-radar: Multi-signal risk scoring (0-100, A-F grade) combining on-chain and market data
- upgrade-monitor: EIP-1967 proxy contract detection with implementation and admin storage slot inspection
- contract-audit: Smart contract security analysis covering ownership, proxy patterns, and token standards compliance

All skills use live BSC JSON-RPC data and DexScreener market feeds.
Each includes full API documentation with example requests and response schemas.
Skills:
- sniper-detector: Detect bot sniping on any token by analyzing early block buyers, hold/dump tracking, and snipe score (0-100)
- copy-trade: Real-time alpha wallet activity monitor tracking known wallets for token interactions across recent blocks
- smart-money: Whale transaction tracker identifying large-value BNB transfers with wallet labeling and direction classification
- wallet-cluster: On-chain forensics tool discovering connected wallets via BNB transfer patterns and shared token holdings

All skills use live BSC JSON-RPC data with block scanning and receipt analysis.
Each includes full API documentation with example requests and response schemas.
Skills:
- dex-arb: Cross-DEX price discrepancy finder comparing prices across PancakeSwap, BiSwap, and other BSC DEXes with gas-adjusted profit estimates
- token-battle: Side-by-side comparison of up to 4 tokens showing price, volume, liquidity, burns, and 24h performance
- token-birth: Token genesis analysis with creator wallet profiling, supply distribution breakdown, and liquidity history tracking
- pair-analytics: Deep DEX pair analysis aggregating stats across multiple trading pairs for any BSC token
- pancakeswap-arena: PancakeSwap top pairs dashboard showing volume leaders, liquidity depth, and trending tokens

All skills use live DexScreener market data and BSC JSON-RPC.
Each includes full API documentation with example requests and response schemas.
Skills:
- tx-decoder: Decode any BSC transaction into human-readable function calls, event logs, and token transfers with gas breakdown
- block-autopsy: Block-level gas distribution analysis with transaction type breakdown and top gas consumer identification
- token-flow: Track real-time token transfer movements by scanning recent block receipts for Transfer events
- burn-tracker: Real-time BNB and token burn tracking with live USD valuations from DexScreener
- wallet-scanner: Complete wallet portfolio analysis showing BNB and top BSC token balances with current USD values
- portfolio-heatmap: Bloomberg-style portfolio heatmap with 24h performance coloring, health score, and concentration analysis

All skills use live BSC JSON-RPC data with block and receipt scanning.
Each includes full API documentation with example requests and response schemas.
Skills:
- validator-map: Live BSC validator monitoring tracking all 21 PoSA validators with gas utilization, block production stats, and MEV detection
- network-pulse: Network congestion gauge scoring pressure 0-100 with TPS measurement, block timing analysis, and gas optimization recommendations
- bsc-supremacy: BSC vs Ethereum head-to-head comparison using live data for block time, TPS, gas costs, and finality speed
- gas-calculator: Operation cost estimator computing gas costs for 10 common operations with BSC vs ETH savings comparison
- chain-vitals: Core network health dashboard showing block height, gas price, peer count, and sync status

All skills use live BSC JSON-RPC data with multi-block analysis.
Each includes full API documentation with example requests and response schemas.
Skills:
- yield-finder: APY estimation engine analyzing trading fee revenue across BSC DEX pairs to identify the highest yield opportunities
- defi-leaderboard: Top DeFi protocols ranked by total value locked, trading volume, and active user metrics
- liquidity-pulse: Real-time liquidity depth analysis across major BSC trading pairs with concentration and movement tracking

All skills use live DexScreener market data and BSC JSON-RPC.
Each includes full API documentation with example requests and response schemas.
feat: Add 6 BSC Security Analysis Skills
feat: Add 4 BSC Alpha Intelligence Skills
feat: Add 5 BSC Market Analysis Skills
feat: Add 6 BSC On-Chain Analytics Skills
feat: Add 5 BSC Network and Infrastructure Skills
feat: Add 3 BSC DeFi Analysis Skills
Portfolio snapshot via on-chain RPC — BNB balance plus top 15 BSC token
holdings with live prices and wallet activity classification.
Cross-chain capital flow analysis via bridge contract balances on BSC.
Monitors 6 major bridges: Stargate, Celer, Multichain, LayerZero,
Wormhole, and Axelar.
Real fee revenue vs TVL ranking for BSC DeFi protocols. Sources data
from DefiLlama to rank protocols by daily fees, revenue, and
capital efficiency ratio.
Composite BSC dominance score vs other L1/L2 chains. Weighs TVL (40%),
DEX volume (30%), fees (20%), and cost efficiency (10%) using DefiLlama
and BSC RPC data.
BNB staking ecosystem analysis — total staked BNB, liquid staking
protocol comparison (slisBNB, ankrBNB, BNBx, stkBNB, rBNB), and
APY benchmarks via on-chain data.
feat: add Bridge Flow Monitor skill (#70)
feat: add Protocol Revenue Leaderboard skill (#71)
feat: add Wallet PnL Tracker skill (#69)
feat: add Chain Dominance Index skill (#72)
feat: add Staking Intelligence skill (#73)
## Summary
- Balance and transfer tool parameters lacked explicit required/optional annotations
- ENS name resolution support for toAddress was undocumented

## Type of Change
- [x] Documentation fix

## Changes Made
- get_erc20_balance: marked `address` as required
- get_native_balance: clarified address is optional (derived from privateKey)
- transfer_native_token, transfer_erc20: added ENS name resolution support note for toAddress

## Testing
- [x] Verified against MCP source tool parameter schemas
@hashdit-bot
Copy link

hashdit-bot bot commented Mar 14, 2026

Pull Request Review

This PR significantly expands the repository from a narrow MCP skill doc set into a full-stack BNB Chain analytics project, adding extensive documentation, a FastAPI backend scaffold (including shared caching utilities), and a frontend dashboard framework with panel/layout infrastructure. It also updates MCP reference docs to clarify parameter semantics, notably making address required for get_erc20_balance and documenting ENS name support for transfer destinations. Additionally, it introduces CODEOWNERS and many new SKILL.md specs describing API endpoints and expected responses.

Sensitive Content

Blockchain Address:

  • 0x0E09FaBB73Bd3Ade0a17ECC321fD13a19e81cE82 (Ethereum/BSC address) in README.md and multiple skills/**/*.md files — used in API examples
  • 0x8894E0a0c962CB723c1ef8a1B6737B4E1e2AE02b (Ethereum/BSC address) in multiple skills/**/*.md files — example wallet address
  • 0x10ED43C718714eb63d5aA57B78B54917c3e6fE49 (Ethereum/BSC address) in multiple skills/**/*.md files — example router/spender address
  • Multiple additional on-chain addresses added across skills/**/*.md and README.md as sample data/endpoints

Social Account:

  • @mefai-dev (GitHub handle) in .github/CODEOWNERS — code ownership mapping
  • https://mefai.io / https://mefai.io/superbsc (project website) in README.md, frontend/index.html, and many skills/**/*.md files — project/demo links

Security Issues

🟠 [HIGH] Overly permissive CORS configuration on public API

File: api/main.py
The API enables allow_origins=["*"], allow_methods=["*"], and allow_headers=["*"], allowing any website to make browser-based requests to all endpoints. For a public analytics API this may still be intentional, but in production this materially increases abuse surface (cross-origin scraping/automated consumption and easier integration by malicious origins), and becomes a serious issue if any sensitive endpoints are later added.
Recommendation: Restrict CORS to explicit trusted origins, scope allowed methods/headers minimally, and gate any future privileged endpoints behind authentication before rollout.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant