Skip to content

refactor: use t.TempDir() instead of os.MkdirTemp #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tgolang wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −2
Draft

refactor: use t.TempDir() instead of os.MkdirTemp #3479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eth/protocols/eth/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"math"
"math/big"
"math/rand"
"os"

Check failure on line 27 in eth/protocols/eth/handler_test.go

View workflow job for this annotation

GitHub Actions / golang-lint (1.24.x, ubuntu-latest) 

"os" imported and not used

Check failure on line 27 in eth/protocols/eth/handler_test.go

View workflow job for this annotation

GitHub Actions / unit-test (1.24.x, ubuntu-latest) 

"os" imported and not used
"testing"
"time"

Expand Down Expand Up @@ -136,8 +136,7 @@
txconfig := legacypool.DefaultConfig
txconfig.Journal = "" // Don't litter the disk with test journals

storage, _ := os.MkdirTemp("", "blobpool-")
defer os.RemoveAll(storage)
storage := t.TempDir()

Check failure on line 139 in eth/protocols/eth/handler_test.go

View workflow job for this annotation

GitHub Actions / golang-lint (1.24.x, ubuntu-latest) 

undefined: t (typecheck)

Check failure on line 139 in eth/protocols/eth/handler_test.go

View workflow job for this annotation

GitHub Actions / unit-test (1.24.x, ubuntu-latest) 

undefined: t

blobPool := blobpool.New(blobpool.Config{Datadir: storage}, chain, nil)
legacyPool := legacypool.New(txconfig, chain)
Expand Down
Loading