Skip to content

chore: fix comment syntax issues in miner and verkle witness test files #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nuxtreact wants to merge 1 commit into from
+5 −5
Closed

chore: fix comment syntax issues in miner and verkle witness test files #3558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/verkle_witness_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ func TestProcessVerkleSelfDestructInSeparateTx(t *testing.T) {
account2.Bytes(),
[]byte{byte(vm.SELFDESTRUCT)})

//The goal of this test is to test SELFDESTRUCT that happens in a contract
// The goal of this test is to test SELFDESTRUCT that happens in a contract
// execution which is created in a previous transaction.
selfDestructContract := slices.Concat([]byte{
byte(vm.PUSH1), byte(len(runtimeCode)),
Expand Down
8 changes: 4 additions & 4 deletions miner/ordering.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func (t *transactionsByPriceAndNonce) Forward(tx *types.Transaction) {
for _, head := range t.heads {
if head.tx != nil && head.tx.Resolve() != nil {
if tx == head.tx.Tx {
//shift t to the position one after tx
// Shift t to the position one after tx
txTmp := t.PeekWithUnwrap()
for txTmp != tx {
t.Shift()
Expand All @@ -220,13 +220,13 @@ func (t *transactionsByPriceAndNonce) Forward(tx *types.Transaction) {
}
}
}
//get the sender address of tx
// Get the sender address of tx
acc, _ := types.Sender(t.signer, tx)
//check whether target tx exists in t.txs
// Check whether target tx exists in t.txs
if txs, ok := t.txs[acc]; ok {
for _, txLazyTmp := range txs {
if txLazyTmp != nil && txLazyTmp.Resolve() != nil {
//found the same pointer in t.txs as tx and then shift t to the position one after tx
// Found the same pointer in t.txs as tx and then shift t to the position one after tx
if tx == txLazyTmp.Tx {
txTmp := t.PeekWithUnwrap()
for txTmp != tx {
Expand Down
Loading