Skip to content

feat: implement mendel HF #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatusKysel wants to merge 3 commits into
base: feat/update-to-latest-reth
Choose a base branch
from
Open

feat: implement mendel HF #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a7c48d
feat: implement mendel HF
MatusKysel Jan 30, 2026
4d1d54e
fix(evm): bypass EIP-7825 gas limit cap for BSC system transactions
MatusKysel Feb 2, 2026
bbbba4f
feat(tests): add support of eth spec tests
MatusKysel Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,094 changes: 569 additions & 525 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

86 changes: 45 additions & 41 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[workspace]
members = [".", "testing/bsc-ef-tests"]

[package]
name = "reth_bsc"
version = "0.1.0"
Expand All @@ -13,57 +16,58 @@ name = "reth-bsc"
path = "src/main.rs"

[dependencies]
reth = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-cli = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-cli-commands = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-basic-payload-builder = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-db = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-engine-local = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-chainspec = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-cli-util = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-discv4 = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb", features = [
reth = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-cli = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-cli-commands = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-basic-payload-builder = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-db = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-engine-local = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-chainspec = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-cli-util = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-discv4 = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle", features = [
"test-utils",
] }
reth-engine-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-ethereum-forks = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb", features = [
reth-engine-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-ethereum-forks = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle", features = [
"serde",
] }
reth-ethereum-payload-builder = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-payload-builder-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-chain-state = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-ethereum-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-eth-wire = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-eth-wire-types = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-evm = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-evm-ethereum = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-execution-types = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-ipc = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-metrics = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-node-core = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-revm = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-network = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb", features = [
reth-ethereum-payload-builder = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-payload-builder-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-chain-state = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-ethereum-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-eth-wire = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-eth-wire-types = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-evm = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-evm-ethereum = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-execution-types = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-ipc = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-metrics = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-node-core = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-revm = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-network = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle", features = [
"test-utils",
] }
reth-network-p2p = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-network-api = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-node-ethereum = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb", features = [
reth-network-p2p = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-network-api = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-node-ethereum = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle", features = [
"test-utils",
] }
reth-network-peers = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-payload-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-ethereum-engine-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-primitives-traits = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-provider = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb", features = [
reth-network-peers = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-payload-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-ethereum-engine-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-primitives = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-primitives-traits = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-provider = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle", features = [
"test-utils",
] }
reth-rpc-eth-api = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-rpc-convert = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-rpc-engine-api = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-trie-common = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-trie-db = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-tasks = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-transaction-pool = { git = "https://github.com/bnb-chain/reth.git", branch = "rebase-v1.10.2-bnb" }
reth-rpc-eth-api = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-rpc-convert = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-rpc-engine-api = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-rpc-server-types = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-trie-common = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-trie-db = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-tasks = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
reth-transaction-pool = { git = "https://github.com/bnb-chain/reth.git", branch = "feat/eip7594-sidecar-toggle" }
revm = "34.0.0"
revm-context-interface = "14.0.0"
revm-database = "10.0.0"
Expand Down
27 changes: 27 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,30 @@ check-features:
--package reth-primitives-traits \
--package reth-primitives \
--feature-powerset

##@ EVM Tests

# Execution spec tests configuration
EEST_VERSION ?= v5.4.0
EEST_URL := https://github.com/ethereum/execution-spec-tests/releases/download/$(EEST_VERSION)/fixtures_stable.tar.gz
EEST_DIR := ./testing/bsc-ef-tests/execution-spec-tests

$(EEST_DIR):
@echo "Downloading execution spec tests $(EEST_VERSION)..."
mkdir -p $(EEST_DIR)
curl -sL $(EEST_URL) | tar -xzf - --strip-components=1 -C $(EEST_DIR)

.PHONY: download-eest
download-eest: $(EEST_DIR) ## Download execution spec test fixtures

.PHONY: ef-tests
ef-tests: $(EEST_DIR) ## Run BSC EVM execution spec tests
cargo test -p bsc-ef-tests --release --features ef-tests,jemalloc,asm-keccak

.PHONY: ef-tests-nextest
ef-tests-nextest: $(EEST_DIR) ## Run BSC EVM execution spec tests with nextest (faster)
cargo nextest run -p bsc-ef-tests --release --features ef-tests,jemalloc,asm-keccak

.PHONY: clean-eest
clean-eest: ## Remove downloaded execution spec test fixtures
rm -rf $(EEST_DIR)
21 changes: 21 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,27 @@ make build
make maxperf
```

## Testing

### Ethereum Execution Spec Tests

Run the [Ethereum Execution Spec Tests](https://github.com/ethereum/execution-spec-tests) to validate BSC EVM compatibility:

```bash
# Download test fixtures (v5.4.0)
make download-eest

# Run tests
make ef-tests

# Or use nextest for faster parallel execution (requires cargo-nextest)
# Install with: cargo install cargo-nextest
make ef-tests-nextest

# Clean up test fixtures
make clean-eest
```

## Running

### Full Node (Recommended)
Expand Down
11 changes: 10 additions & 1 deletion src/chainspec/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,11 @@ fn add_hardforks_to_chainspec(
if let Some(prague_time) = config.get("pragueTime").and_then(|v| v.as_u64()) {
chain_spec = chain_spec.with_fork(EthereumHardfork::Prague, ForkCondition::Timestamp(prague_time));
}

if let Some(osaka_time) = config.get("osakaTime").and_then(|v| v.as_u64()) {
chain_spec = chain_spec.with_fork(EthereumHardfork::Osaka, ForkCondition::Timestamp(osaka_time));
chain_spec = chain_spec.with_fork(BscHardfork::Osaka, ForkCondition::Timestamp(osaka_time));
}

if let Some(pascal_time) = config.get("pascalTime").and_then(|v| v.as_u64()) {
chain_spec = chain_spec.with_fork(BscHardfork::Pascal, ForkCondition::Timestamp(pascal_time));
Expand All @@ -210,6 +215,10 @@ fn add_hardforks_to_chainspec(
if let Some(fermi_time) = config.get("fermiTime").and_then(|v| v.as_u64()) {
chain_spec = chain_spec.with_fork(BscHardfork::Fermi, ForkCondition::Timestamp(fermi_time));
}

if let Some(mendel_time) = config.get("mendelTime").and_then(|v| v.as_u64()) {
chain_spec = chain_spec.with_fork(BscHardfork::Mendel, ForkCondition::Timestamp(mendel_time));
}

Ok(chain_spec)
}
}
Loading
Loading