Use mergeContents instead of appending code to the end of file in withPodfile #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowczarz
changed the title
nathan-ahn
requested changes
Dec 10, 2024
Collaborator
nathan-ahn
left a comment
nathan-ahn
left a comment
There was a problem hiding this comment.
Good catch and thank you for the fix! I didn't realize that the targets were nested due to how Podfile was indented when I first implemented the merge.
On that note, can you revise this PR to indent the contents of appClipTarget? I've been trying to maintain consistent indentation within the Podfile to avoid confusion around start and end blocks.
I've tested this change locally and it seems to be non-breaking. Once this is merged in, we can make this fix the v0.5.1 release. Are there any breaking changes caused by this that I'm not seeing here?
kowczarz
commented
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order of adding targets described in podfile does matters. In previous versions of the plugin Clip target was added inside the main target. In #48 that was changed and the Clip target was separated and it caused the change in the build scripts phase. In our project we have some custom build scripts which are based on previous behaviour, and the 0.4.0 update caused many issues by that minor change.
In my PR I'm getting back to using merge contents, but my anchor is much safer, because it's very unlikely expo will get rid of
use_expo_modules!and just in case they will add something to the call, we are using offset 0, what causes the contents are merged just before the mentioned line.