Skip to content

Expo 53 Support #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathan-ahn merged 3 commits into from
May 10, 2025
Merged

Expo 53 Support #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
437862d
Prebuild fix
nathan-ahn May 10, 2025
2ee3ee7
Matching new podfile
nathan-ahn May 10, 2025
2daa6ac
Capitalization fix
nathan-ahn May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions plugin/src/withPodfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,8 @@ export const withPodfile: ConfigPlugin<{
config_command = ['node', '-e', "process.argv=['', '', 'config'];require('@react-native-community/cli').run()"];
else
config_command = [
'node',
'--no-warnings',
'--eval',
'require(require.resolve(\\'expo-modules-autolinking\\', { paths: [require.resolve(\\'expo/package.json\\')] }))(process.argv.slice(1))',
'npx',
'expo-modules-autolinking',
'react-native-config',
'--json',
'--platform',
Expand Down
2 changes: 1 addition & 1 deletion plugin/src/xcode/addBuildPhases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export function addBuildPhases(
const buildPath = `"$(CONTENTS_FOLDER_PATH)/AppClips"`;
const folderType = "watch2_app"; // "watch2_app" uses the same subfolder spec (16), app_clip does not exist in cordova-node-xcode yet

const buildPhaseFiles = ["AppDelegate.mm", "main.m"];
const buildPhaseFiles = ["AppDelegate.swift"];

// Add shell script build phase "Start Packager"
xcodeProject.addBuildPhase(
Expand Down
8 changes: 2 additions & 6 deletions plugin/src/xcode/addPbxGroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ export function addPbxGroup(

const filesToCopy = [
"SplashScreen.storyboard",
"AppDelegate.h",
"AppDelegate.mm",
"main.m",
"AppDelegate.swift",
];

for (const file of filesToCopy) {
Expand All @@ -39,9 +37,7 @@ export function addPbxGroup(
// Add PBX group
const { uuid: pbxGroupUuid } = xcodeProject.addPbxGroup(
[
"AppDelegate.h",
"AppDelegate.mm",
"main.m",
"AppDelegate.swift",
"Info.plist",
"Images.xcassets",
"SplashScreen.storyboard",
Expand Down