Added a function that can delete a view by name && fixed the problem of capitalizing the wrong field.#326
Closed
Ethan-622 wants to merge 2 commits intobndr:masterfrom
Closed
Added a function that can delete a view by name && fixed the problem of capitalizing the wrong field.#326Ethan-622 wants to merge 2 commits intobndr:masterfrom
Ethan-622 wants to merge 2 commits intobndr:masterfrom
Conversation
Collaborator
|
Can you please rebase your change + add some tests? |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Contributor
Author
I have rebased and resubmitted the branch as feature/add delete view, and added unit testing. |
Collaborator
|
So we can close that one, right? |
Contributor
Author
of course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.