biz.aQute.bnd.annotation: compile with java 8 #7033
Merged
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove Java 9+ features: It was simply the attributes of the `@Deprecated` annotation. So we just put that into the comment and use plain `@Deprecated` which is Java8 compatible. The enforce compilation with java8 Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
Contributor
|
Supporting Java 8 is a good idea from my point for now. |
Contributor
Author
|
|
Contributor
|
For annotation I think its fine keep them at java8 I see no benefit in any higher java version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7005
remove Java 9+ features: It was simply the attributes of the
@Deprecatedannotation. So we just put that into the comment and use plain@Deprecatedwhich is Java8 compatible.Then enforced compilation with java8
TODO: Not sure if we really want to do this or what the drawbacks are. Maybe with bnd 8.0.0 we should remove java 8 support fully.