forked from jupyterhub/jupyterhub-deploy-docker
-
Notifications
You must be signed in to change notification settings - Fork 0
move over notebook env config #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
antonjs
wants to merge
86
commits into
bnext-bio:main
Choose a base branch
from
fuad00:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 6917060, docker compose relies on an oauth.env file to get the OAuth parameters, so the Makefile is updated to handle here this change. In addition, the README is updated.
Add oauth.env target to Makefile
Update and rename LICENSE.md to LICENSE
…terhub-k8s Mention zero-to-jupyterhub-k8s project in README
and use it as a build arg for the Hub and single-use images
Use JUPYTERHUB_VERSION as a build arg
…eclaration in the official postgres image Dockerfile Otherwise docker-compose creates an unamed volume mounted at /var/lib/postgresql/data along with the jupyterhub-db-data volume.
Change mountpoint of the PostgreSQL database
Probably on account of docker/docker-py#1543
volume_driver is no longer a keyword argument to create_container()
It's a habit for some developers to append a newline at the end of the file, but line 82 did not take this into consideration. And the consequence is that JupyterHub would keep restarting.
in case of newline at the end of userlist file
jupyterhub 0.9.2
Remove most configuration, get this working
…ctions/actions/checkout-4 Bump actions/checkout from 3 to 4
…update Update pre-commit config
Switch to Quay.io for all the images
Switch to Docker Compose v2
Use lint from pre-commit.ci, remove redundant job
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
updates: - [github.com/psf/black: 23.10.1 → 23.12.1](psf/black@23.10.1...23.12.1) - [github.com/pre-commit/mirrors-prettier: v3.0.3 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.0.3...v4.0.0-alpha.8)
…ctions/actions/setup-python-5 Bump actions/setup-python from 4 to 5
…e-config [pre-commit.ci] pre-commit autoupdate
updates: - [github.com/psf/black: 23.12.1 → 24.1.1](psf/black@23.12.1...24.1.1) - [github.com/PyCQA/flake8: 6.1.0 → 7.0.0](PyCQA/flake8@6.1.0...7.0.0)
…e-config [pre-commit.ci] pre-commit autoupdate
updates: - [github.com/psf/black: 24.1.1 → 24.3.0](psf/black@24.1.1...24.3.0)
…e-config [pre-commit.ci] pre-commit autoupdate
updates: - [github.com/psf/black: 24.3.0 → 24.4.2](psf/black@24.3.0...24.4.2) - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) - [github.com/hadolint/hadolint.git: v2.12.1-beta → v2.13.0-beta](https://github.com/hadolint/hadolint.git/compare/v2.12.1-beta...v2.13.0-beta)
…e-config [pre-commit.ci] pre-commit autoupdate
updates: - [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0)
…e-config [pre-commit.ci] pre-commit autoupdate
allow all signed-up admin users to login by default
updates: - [github.com/psf/black: 24.4.2 → 24.10.0](psf/black@24.4.2...24.10.0) - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/hadolint/hadolint.git: v2.13.0-beta → v2.13.1-beta](https://github.com/hadolint/hadolint.git/compare/v2.13.0-beta...v2.13.1-beta) - [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
…e-config [pre-commit.ci] pre-commit autoupdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.