Normalize local-part to NFKC; normalize IDN to Unicode rather than ASCII#28
Merged
Normalize local-part to NFKC; normalize IDN to Unicode rather than ASCII#28
Conversation
Contributor
andersk
commented
Nov 6, 2025
andersk
commented
- Fixes NFKC requirement from https://www.unicode.org/reports/tr39/#Email_Security_Profiles.
- Fixes Allow normalizing IDN to Unicode rather than ASCII #24.
Rust’s str and String types already guarantee their contents to be valid UTF-8 as a safety invariant, so this doesn’t check anything. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
changed the title
andersk
force-pushed
the
unicode
branch
2 times, most recently
from
469343e to
3ee0bae
Compare
This is required by https://www.unicode.org/reports/tr39/#Email_Security_Profiles. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Change normalized and domain_name to use the Unicode form of the domain. Return the ASCII form of the domain as ascii_domain, and the ASCII form of the email (if it exists) as ascii_email. These changes match the behavior of email-validator. Fixes bnkc#24. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
commented
Nov 6, 2025
| @pytest.mark.parametrize( | ||
| ("s", "expected_error"), | ||
| [ | ||
| ("\u2005", "FOUR-PER-EM SPACE"), # four-per-em space (Zs) |
Contributor
Author
There was a problem hiding this comment.
(This gets NFKC-normalized to an ASCII space character, resulting in a different error message.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.