decrease windows dependency by changing from bcrypt to bcrypt-nodejs#121
Open
AdrianScott wants to merge 2 commits intobnoguchi:masterfrom
Open
decrease windows dependency by changing from bcrypt to bcrypt-nodejs#121AdrianScott wants to merge 2 commits intobnoguchi:masterfrom
AdrianScott wants to merge 2 commits intobnoguchi:masterfrom
Conversation
change bcrypt -> bcrypt-nodejs to support windows dev/deployment without ms visual studio / windows sdk dependency
change bcrypt -> bcrypt-nodejs to support windows dev/deployment without ms visual studio / windows sdk dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
bcrypt usage on Windows currently requires extensive installation of windows SDK, requiring gigabytes of downloads etc.
The newly-released bcrypt-nodejs offers an alternative without this requirement, while using essentially the same API.
In these commits, I propose a change bcrypt -> bcrypt-nodejs to support windows dev/deployment without ms visual studio / windows sdk dependency.
Thank you for considering this suggestion.