-
Notifications
You must be signed in to change notification settings - Fork 6
Add first blog post for temporal_rs and general Boa Temporal work #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work! Nice read! 👏
Just some minor non-blocking comments 😄
Co-authored-by: Haled Odat <[email protected]>
Co-authored-by: Haled Odat <[email protected]>
Co-authored-by: Haled Odat <[email protected]>
Co-authored-by: Haled Odat <[email protected]>
Co-authored-by: Haled Odat <[email protected]>
Co-authored-by: Haled Odat <[email protected]>
Co-authored-by: Haled Odat <[email protected]>
Co-authored-by: Haled Odat <[email protected]>
Co-authored-by: Haled Odat <[email protected]>
Co-authored-by: Haled Odat <[email protected]>
Co-authored-by: Haled Odat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice. Sorry for the comment dump, I just had a lot of ideas on how to improve the grammar of some sections 😅
Also, maybe we should link to the corresponding specification of each built-in, in case people are curious and want to check them out.
blog/temporal-introduction.md
Outdated
So after the prototype was merged, the prototype was pulled out of Boa's | ||
internal builtins and externalized into its own crate, | ||
[`temporal_rs`][temporal-rs-repo], which then first landed behind an | ||
experimental flag in Boa v0.18. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So after the prototype was merged, the prototype was pulled out of Boa's | |
internal builtins and externalized into its own crate, | |
[`temporal_rs`][temporal-rs-repo], which then first landed behind an | |
experimental flag in Boa v0.18. | |
So, after the prototype was merged, the prototype was pulled out of Boa's | |
internal builtins and externalized into its own crate, | |
[temporal_rs][temporal-rs-repo], which landed behind an | |
experimental flag in Boa v0.18 at first. |
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just found some small fixes, but it's looking pretty much ready IMO
blog/2025-06-15-temporal-impl-1.md
Outdated
|
||
Once we've constructed `Now`, then we are off to the races! | ||
|
||
In Boa, implementing `Now` is as easy the below implementation for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording seems a bit wonky here. "is as easy the below" specifically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I tried rewording it in a new commit. Matching it up with the tone of "off to the races" is a bit odd I think.
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An additional small comment that doesn't block the PR. Nice work!
Co-authored-by: José Julián Espina <[email protected]>
This adds a first blog post discussing some of the general work on temporal and temporal_rs.
Let me know what you think / if you think there's anything else we should highlight here.