Skip to content

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jun 14, 2025

This adds a first blog post discussing some of the general work on temporal and temporal_rs.

Let me know what you think / if you think there's anything else we should highlight here.

@HalidOdat HalidOdat self-requested a review June 14, 2025 20:57
@nekevss nekevss marked this pull request as ready for review June 14, 2025 23:15
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! Nice read! 👏

Just some minor non-blocking comments 😄

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice. Sorry for the comment dump, I just had a lot of ideas on how to improve the grammar of some sections 😅

Also, maybe we should link to the corresponding specification of each built-in, in case people are curious and want to check them out.

Comment on lines 55 to 58
So after the prototype was merged, the prototype was pulled out of Boa's
internal builtins and externalized into its own crate,
[`temporal_rs`][temporal-rs-repo], which then first landed behind an
experimental flag in Boa v0.18.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
So after the prototype was merged, the prototype was pulled out of Boa's
internal builtins and externalized into its own crate,
[`temporal_rs`][temporal-rs-repo], which then first landed behind an
experimental flag in Boa v0.18.
So, after the prototype was merged, the prototype was pulled out of Boa's
internal builtins and externalized into its own crate,
[temporal_rs][temporal-rs-repo], which landed behind an
experimental flag in Boa v0.18 at first.

nekevss and others added 10 commits June 15, 2025 13:19
nekevss and others added 14 commits June 15, 2025 13:59
@nekevss nekevss requested a review from jedel1043 June 15, 2025 19:58
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just found some small fixes, but it's looking pretty much ready IMO


Once we've constructed `Now`, then we are off to the races!

In Boa, implementing `Now` is as easy the below implementation for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording seems a bit wonky here. "is as easy the below" specifically

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I tried rewording it in a new commit. Matching it up with the tone of "off to the races" is a bit odd I think.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An additional small comment that doesn't block the PR. Nice work!

@nekevss nekevss merged commit b39ab9e into main Jun 15, 2025
1 check passed
@nekevss nekevss deleted the temporal-blog-post branch June 15, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants