Skip to content

Add Url Searchparams to ConformanceView #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 5, 2025
Merged

Add Url Searchparams to ConformanceView #197

merged 6 commits into from
Jul 5, 2025

Conversation

nhancodes
Copy link
Contributor

closes #194

  • add url search parameters to conformance state
  • add url state for state initialization
  • render conformance state based on url state

@nekevss nekevss requested a review from a team June 28, 2025 22:31
nekevss
nekevss requested changes Jun 28, 2025
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

Have one issue, but nothing too big.

nhancodes and others added 2 commits June 30, 2025 08:30
@nhancodes @nekevss
Update src/components/conformance/utils.ts
56b4a6b 
guard clause for when `testPath` only contains version

Co-authored-by: Kevin Ness <[email protected]>
@nhancodes
search param fix
7fd97f6
@nhancodes nhancodes requested a review from nekevss July 5, 2025 17:20
nekevss
nekevss approved these changes Jul 5, 2025
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks!

@nekevss nekevss merged commit 66dedb3 into boa-dev:main Jul 5, 2025
1 check passed
Timkarx pushed a commit to Timkarx/boa-dev.github.io that referenced this pull request Jul 7, 2025
@nhancodes @nekevss @Timkarx
Add Url Searchparams to ConformanceView (boa-dev#197)
8bdca68 
* feat-search-params

* prettier and lint

* conformance/index move updateInitialConformanceState above useEffect

* Update src/components/conformance/utils.ts

guard clause for when `testPath` only contains version

Co-authored-by: Kevin Ness <[email protected]>

* search param fix

* fix/refactor: default to version main when version is undefine

---------

Co-authored-by: nonbots <non@bot>
Co-authored-by: Kevin Ness <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use UrlSearchParams with conformance page navigation
2 participants
@nhancodes @nekevss