Skip to content

Add a filter option to the conformance page #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2025
Merged

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jul 4, 2025

This PR adds a conformance filter option to filter tests between passed, ignored, and failed.

image

image

@nekevss nekevss requested a review from a team July 4, 2025 14:51
@nekevss nekevss force-pushed the conformance-filter-option branch from 2abd5de to b56f124 Compare July 5, 2025 17:45
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally! Really nice addition! Looks good from my side! 😄

NOTE: I'm not that experienced with React... 😅

@nekevss nekevss merged commit bcf6d32 into main Jul 6, 2025
1 check passed
@nekevss nekevss deleted the conformance-filter-option branch July 6, 2025 15:43
Timkarx pushed a commit to Timkarx/boa-dev.github.io that referenced this pull request Jul 7, 2025
* Add a filter option to conformance page

* npm run format

* JSX.Element => React.ReactNode

* Fix bug with filter not persisting when sortOption was selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants