Skip to content

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Oct 2, 2023

Just some small improvements in our CI to ensure we're testing everything.

One unfortunate thing I realized is that cargo clippy -- -D warnings apparently doesn't work with our current setup, somehow. I think clippy is interpreting our crate global warns as overriding the command argument -D warnings, but it seems that this was fixed on rust-lang/rust-clippy#5749. Maybe the bug reappeared for workspaces?

Anyways, I confirmed that the warnings do error with the new [lints] section for Cargo.toml, so this should be fixed when Rustc 1.74 releases. I'll probably open a new draft PR for that, just to have a reminder to merge the changes at that time. In the meantime, let's just ensure we check the actions for any warnings before merging any PR.

@jedel1043 jedel1043 added the github_actions Pull requests that update Github_actions code label Oct 2, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Oct 2, 2023
@jedel1043 jedel1043 requested a review from a team October 2, 2023 00:06
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,201 75,201 0
Ignored 19,482 19,482 0
Failed 891 891 0
Panics 0 0 0
Conformance 78.68% 78.68% 0.00%

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (e54609e) 49.42% compared to head (9ad8b1f) 49.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3333      +/-   ##
==========================================
- Coverage   49.42%   49.41%   -0.02%     
==========================================
  Files         445      445              
  Lines       43891    43898       +7     
==========================================
- Hits        21691    21690       -1     
- Misses      22200    22208       +8     
Files Coverage Δ
boa_cli/src/main.rs 0.61% <ø> (ø)
boa_engine/src/vm/mod.rs 61.42% <ø> (ø)
boa_engine/src/vm/opcode/mod.rs 5.32% <ø> (ø)
boa_runtime/src/console/mod.rs 41.93% <ø> (ø)
boa_examples/src/bin/commuter_visitor.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/symbol_visitor.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/modules.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/runtime_limits.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/loadfile.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/jsdate.rs 0.00% <0.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 requested review from nekevss and a team October 2, 2023 02:49
@nekevss nekevss requested a review from a team October 2, 2023 03:22
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@jedel1043 jedel1043 added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit d8f6834 Oct 2, 2023
@jedel1043 jedel1043 deleted the ci-improvements branch October 3, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants