Skip to content

Some string cleanups#4090

Merged
jedel1043 merged 4 commits intoboa-dev:mainfrom
CrazyboyQCD:string-cleanups
Feb 26, 2025
Merged

Some string cleanups#4090
jedel1043 merged 4 commits intoboa-dev:mainfrom
CrazyboyQCD:string-cleanups

Conversation

@CrazyboyQCD
Copy link
Contributor

@CrazyboyQCD CrazyboyQCD commented Dec 18, 2024

  • Simplify JsString::as_str (miri passed, decrease the size of cli executable by ~5kb under release mode (28,680kb => 28,675kb) )
  • Replace soft deprecated addr_of* macro with & [const|mut] raw
  • Mark some &mut self tagged methods const

@CrazyboyQCD CrazyboyQCD marked this pull request as ready for review December 18, 2024 02:31
@CrazyboyQCD CrazyboyQCD marked this pull request as draft December 18, 2024 02:35
@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (6ddc2b4) to head (518d9ad).
Report is 382 commits behind head on main.

Files with missing lines Patch % Lines
core/string/src/lib.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4090      +/-   ##
==========================================
+ Coverage   47.24%   52.95%   +5.71%     
==========================================
  Files         476      488      +12     
  Lines       46892    52465    +5573     
==========================================
+ Hits        22154    27783    +5629     
+ Misses      24738    24682      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyboyQCD CrazyboyQCD marked this pull request as ready for review February 19, 2025 01:02
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good!

@jedel1043 jedel1043 requested a review from a team February 21, 2025 03:44
@jedel1043 jedel1043 added the A-Internal Changes that don't modify execution behaviour label Feb 21, 2025
@jedel1043 jedel1043 added this to the next-release milestone Feb 21, 2025
@jedel1043 jedel1043 added this pull request to the merge queue Feb 26, 2025
Merged via the queue into boa-dev:main with commit e410a68 Feb 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Internal Changes that don't modify execution behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants