Skip to content

Fix typos across the tree#4512

Merged
jedel1043 merged 3 commits intoboa-dev:mainfrom
linkmauve:fix-typos
Oct 31, 2025
Merged

Fix typos across the tree#4512
jedel1043 merged 3 commits intoboa-dev:mainfrom
linkmauve:fix-typos

Conversation

@linkmauve
Copy link
Contributor

This has been done with the help of the wonderful typos tool, and manual review of each individual change. A few changes are my own as well.

This Pull Request fixes/closes no issue.

It changes the following:

  • Many typos have been fixed to be proper English.
  • Of course not all of them.

@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,595 50,595 0
Passed 47,678 47,678 0
Ignored 2,036 2,036 0
Failed 881 881 0
Panics 0 0 0
Conformance 94.23% 94.23% 0.00%

@nekevss
Copy link
Member

nekevss commented Oct 30, 2025

Thanks for fixing these!

We should make it a point to check for types in CI or have a cargo-make recipe for it. How easy is it to work with typo? I think I've heard there's a GitHub action for it, is it relatively nice to use?

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.07%. Comparing base (6ddc2b4) to head (413929e).
⚠️ Report is 580 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/builtins/proxy/mod.rs 16.66% 5 Missing ⚠️
...ngine/src/builtins/temporal/plain_date_time/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4512      +/-   ##
==========================================
+ Coverage   47.24%   57.07%   +9.82%     
==========================================
  Files         476      503      +27     
  Lines       46892    57416   +10524     
==========================================
+ Hits        22154    32768   +10614     
+ Misses      24738    24648      -90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@linkmauve
Copy link
Contributor Author

linkmauve commented Oct 30, 2025

Thanks for fixing these!

We should make it a point to check for types in CI or have a cargo-make recipe for it. How easy is it to work with typo? I think I've heard there's a GitHub action for it, is it relatively nice to use?

Running typos is very easy, you run the typos command and if it returns 2 (or any non-zero status code) it means there are newer typos.

I’ve added a typos.toml file which excludes all false positives I kept in the previous commit.

I have no experience with github actions though.

Also, why is the semver check failing?

@jedel1043
Copy link
Member

why is the semver check failing?

Ignore that for now, we had some breakage with the release of ICU4X 2.1

@linkmauve
Copy link
Contributor Author

I’ve added a GitHub Actions job, and a (temporary) commit adding a typo to check that it indeed fails there, but it doesn’t seem to run here, do you have to do anything on your side to allow for a new job in CI?

@linkmauve
Copy link
Contributor Author

linkmauve commented Oct 31, 2025

CI does fail when there is a new typo! https://github.com/boa-dev/boa/actions/runs/18965726581/job/54191104595?pr=4512

I’ve just removed the commit introducing said typo, to check for the happy path now.

Edit: I’ve done #4517 and #4518 to fix two of the other CI job failures.

This has been done with the help of the wonderful typos[1] tool, and
manual review of each individual change.  A few changes are my own as
well.

[1] https://github.com/crate-ci/typos
It contains the few words we shouldn’t correct in this codebase.
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution!

@jedel1043 jedel1043 added this pull request to the merge queue Oct 31, 2025
@jedel1043 jedel1043 added C-Documentation update documentation C-Actions Pull requests that update Github Actions code A-Internal Changes that don't modify execution behaviour labels Oct 31, 2025
@jedel1043 jedel1043 added this to the v1.0.0 milestone Oct 31, 2025
Merged via the queue into boa-dev:main with commit 0f448cf Oct 31, 2025
18 checks passed
@linkmauve linkmauve deleted the fix-typos branch October 31, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Internal Changes that don't modify execution behaviour C-Actions Pull requests that update Github Actions code C-Documentation update documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants