Conversation
Test262 conformance changes
|
|
Thanks for fixing these! We should make it a point to check for types in CI or have a cargo-make recipe for it. How easy is it to work with typo? I think I've heard there's a GitHub action for it, is it relatively nice to use? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4512 +/- ##
==========================================
+ Coverage 47.24% 57.07% +9.82%
==========================================
Files 476 503 +27
Lines 46892 57416 +10524
==========================================
+ Hits 22154 32768 +10614
+ Misses 24738 24648 -90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Running typos is very easy, you run the I’ve added a I have no experience with github actions though. Also, why is the semver check failing? |
Ignore that for now, we had some breakage with the release of ICU4X 2.1 |
|
I’ve added a GitHub Actions job, and a (temporary) commit adding a typo to check that it indeed fails there, but it doesn’t seem to run here, do you have to do anything on your side to allow for a new job in CI? |
|
CI does fail when there is a new typo! https://github.com/boa-dev/boa/actions/runs/18965726581/job/54191104595?pr=4512 I’ve just removed the commit introducing said typo, to check for the happy path now. Edit: I’ve done #4517 and #4518 to fix two of the other CI job failures. |
This has been done with the help of the wonderful typos[1] tool, and manual review of each individual change. A few changes are my own as well. [1] https://github.com/crate-ci/typos
It contains the few words we shouldn’t correct in this codebase.
It is available as a convenient action: https://github.com/crate-ci/typos/blob/master/docs/github-action.md
jedel1043
left a comment
There was a problem hiding this comment.
Thank you very much for the contribution!
This has been done with the help of the wonderful typos tool, and manual review of each individual change. A few changes are my own as well.
This Pull Request fixes/closes no issue.
It changes the following: