Add support for duplicate named capturing groups in regex#4550
Open
n-faria wants to merge 1 commit intoboa-dev:mainfrom
Open
Add support for duplicate named capturing groups in regex#4550n-faria wants to merge 1 commit intoboa-dev:mainfrom
n-faria wants to merge 1 commit intoboa-dev:mainfrom
Conversation
This implements the TC39 Stage 4 proposal for duplicate named capturing groups in regular expressions. Implementation is in the regress crate (ridiculousfish/regress#136). Once that PR is merged and a new version is published, this PR will be updated with the regress version bump. Fixes boa-dev#4442
Test262 conformance changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4550 +/- ##
==========================================
+ Coverage 47.24% 57.06% +9.82%
==========================================
Files 476 504 +28
Lines 46892 57548 +10656
==========================================
+ Hits 22154 32842 +10688
+ Misses 24738 24706 -32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
added
Blocked
Member
|
PR is unblocked! Regress v0.11 was released a couple of days ago |
jedel1043
added
A-Enhancement
Contributor
|
this mean we should delete line 16 ? 
|
Member
|
Yeah pretty much, but I'm giving the honors of doing this to @n-faria, it's their project after all :) |
Contributor
|
i appreciate that and i respect , They did a great job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR, do not merge yet
This implements the TC39 Stage 4 proposal for duplicate named capturing groups in regular expressions.
This Pull Request fixes/closes #4442.
It changes the following:
-Implementation is in the regress crate (ridiculousfish/regress#136).
See ridiculousfish/regress#136
Once that PR is merged and a new version is published, this PR will be updated with the regress version bump
-That is the only change required, testing was done locally already
-Test cases already exist and are marked as EsNext