Add Initial Debug Adapter Protocol (DAP) Support to Boa#4586
Closed
albertleigh wants to merge 5 commits intoboa-dev:mainfrom
Closed
Add Initial Debug Adapter Protocol (DAP) Support to Boa#4586albertleigh wants to merge 5 commits intoboa-dev:mainfrom
albertleigh wants to merge 5 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4586 +/- ##
==========================================
+ Coverage 47.24% 56.19% +8.95%
==========================================
Files 476 550 +74
Lines 46892 60243 +13351
==========================================
+ Hits 22154 33854 +11700
- Misses 24738 26389 +1651 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Please don't open PRs with 9k new lines of code. |
Contributor
Author
|
okay 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Reviewers,
I am a fan of boa, and I think I could help with a DAP debugger for boa.
This PR adds initial IDE debugging support to Boa CLI through the Debug Adapter Protocol (DAP), enabling developers to debug JavaScript code running in Boa using VS Code or any other DAP-compatible IDE.
Everything was hidden begind core/debugger and cli/dap features, they should not impact the current performance I believed.
And I think it would be a good time to talk about high-level stuffs like:
coreto maintain most of the debug state like spidermonkeyboa-clishould not do too much.then we could settle places to pour more dap message and test again boa engine.
So I just put minimum changes to support debugger instruction and pause and support to resume like:
We could try it like:
cargo.exe build --message-format=json-diagnostic-rendered-ansi --color=always --bin boa --features default,dap --profile dev --manifest-path boa\cli\Cargo.toml/boa/target/debug/boa.exe --dap 4711code .there and run a light weight extension with the taskRun ExtensionTest Boa Debugger.Code_4UOweCvO8o.mp4
Not sure we like this DAP idea or not, maybe too early for boa. I am not that sure. Should Al continue on it? Maybe Al could use it as another starting point and help boa better with more and more features.
Like:
Let Al know whether boa like DAP ~
Thanks
ps:
I noticed we got:
#3978
#4510
Dont be so serious with the markdowns in this pr, I generate with AI
core/engine/src/debugger/README.MD