perf(intl): add benchmarks for Collator, ListFormat, PluralRules, Segmenter, DateTimeFormat and NumberFormat#4898
Merged
jedel1043 merged 8 commits intoboa-dev:mainfrom Mar 12, 2026
Conversation
Test262 conformance changes
Fixed tests (2):Broken tests (157):Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4898 +/- ##
===========================================
+ Coverage 47.24% 58.42% +11.18%
===========================================
Files 476 559 +83
Lines 46892 61459 +14567
===========================================
+ Hits 22154 35910 +13756
- Misses 24738 25549 +811 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
you probably need to update benches/full.rs, otherwise the benchmarks are not registered by Criterion |
Contributor
Author
|
@jedel1043 Thanks for the note! but the Intl benchmarks are auto-discovered by scripts.rs via 
Is this the correct approach, or would you prefer they be integrated |
Member
|
Oh sorry! I thought you were touching the |
Contributor
Author
|
@jedel1043 Thanks for confirming! I will proceed with this then. Do you have any suggestions to add on this benchmarks ? |
Contributor
Author
|
Currently, 
but, Construction is heavier since it now does the formatter creation upfront. |
…cross multiple locales
not yet implemented
Lokesh0224
force-pushed
the
intl-benchmarks
branch
from
ba0fc3f to
db933a1
Compare
Contributor
Author
|
@jedel1043 Could you take a look at this when you get a chance? I'm in the plan of extending the benchmark suite for the remaining Intl APIs then apply the same caching strategy to NumberFormat as I did for DateTimeFormat after verifying with benchmarks. |
Lokesh0224
changed the title
Contributor
Author
|
Summary of this PR, @jedel1043 after reviewing the source for all Intl APIs, DateTimeFormat was the only one reconstructing ICU4X formatter on every format() call. The fix caches the DateTimeFormatter on the struct, created once during construction and cloned in the format closure resulting in around 42% improvement across format and construction benchmarks. |
jedel1043
approved these changes
Mar 12, 2026
Contributor
Author
|
Thanks! |
Contributor
|
hmmm i think with this pr, now |
Member
|
Oh whoops we need to add that feature to the crate in |
Contributor
Author
|
@zhuzhu81998 Thanks for pointing this out. @jedel1043 i'm fixing this right away! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2026
After #4898, running cargo bench -p boa_benches without --features boa_engine/intl_bundled panics with "Intl is not defined" since the Intl benchmark scripts require the intl feature to be enabled. This adds intl_bundled as a default feature for boa_benches so `cargo bench -p boa_benches` works without any panics message: "Intl is not defined".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #4790, adds performance benchmarks for Intl APIs (
Intl.DateTimeFormat, Intl.NumberFormat) to establish baselines for future optimization work.Note
The
format()benchmark uses a fixed date (new Date(2024, 0, 1)) for deterministic results.Cache Optimization
Also caches the DateTimeFormatter on the DateTimeFormat struct instead of recreating it on every format() call. Previously, every format() invocation loaded locale data from the provider from scratch.