Skip to content

Make JsAsyncGenerator fully type safe#5066

Open
jedel1043 wants to merge 2 commits intoboa-dev:mainfrom
jedel1043:type-safe-js-async-generator
Open

Make JsAsyncGenerator fully type safe#5066
jedel1043 wants to merge 2 commits intoboa-dev:mainfrom
jedel1043:type-safe-js-async-generator

Conversation

@jedel1043
Copy link
Member

Replaces the inner JsObject of JsAsyncGenerator with JsObject<AsyncGenerator>, which makes it fully type safe with the addition of the methods inner_next, inner_return and inner_throw.

@jedel1043 jedel1043 added this to the v1.0.0 milestone Mar 14, 2026
@jedel1043 jedel1043 requested a review from a team as a code owner March 14, 2026 17:42
@jedel1043 jedel1043 added C-Builtins PRs and Issues related to builtins/intrinsics A-Internal Changes that don't modify execution behaviour labels Mar 14, 2026
@github-actions
Copy link

github-actions bot commented Mar 14, 2026

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 49,935 49,935 0
Ignored 2,207 2,207 0
Failed 821 821 0
Panics 0 0 0
Conformance 94.28% 94.28% 0.00%

Tested main commit: 1f1cf0301b8a43a5893d535444279b7b11e5b3ce
Tested PR commit: 2a2c77efe96783ae3aeec6a254449ad3a6b815df
Compare commits: 1f1cf03...2a2c77e

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 36.53846% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.01%. Comparing base (6ddc2b4) to head (2a2c77e).
⚠️ Report is 854 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/builtins/async_generator/mod.rs 52.77% 17 Missing ⚠️
...ore/engine/src/object/builtins/jsasyncgenerator.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5066       +/-   ##
===========================================
+ Coverage   47.24%   59.01%   +11.76%     
===========================================
  Files         476      563       +87     
  Lines       46892    62578    +15686     
===========================================
+ Hits        22154    36929    +14775     
- Misses      24738    25649      +911     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043 jedel1043 force-pushed the type-safe-js-async-generator branch from c24f553 to 2a2c77e Compare March 14, 2026 18:56
@jedel1043 jedel1043 added the Waiting On Review Waiting on reviews from the maintainers label Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Internal Changes that don't modify execution behaviour C-Builtins PRs and Issues related to builtins/intrinsics Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant