Skip to content

Implement core disposal logic for explicit resource management #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinavs1920 wants to merge 13 commits into
base: main
Choose a base branch
from

Merge branch 'main' into feat/res2

a684036
Select commit
Loading
Failed to load commit list.
Open

Implement core disposal logic for explicit resource management #5079

Merge branch 'main' into feat/res2
a684036
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 18, 2026 in 1s

59.46% (+12.21%) compared to 6ddc2b4

View this Pull Request on Codecov

59.46% (+12.21%) compared to 6ddc2b4

Details

Codecov Report

❌ Patch coverage is 63.63636% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.46%. Comparing base (6ddc2b4) to head (a684036).
⚠️ Report is 886 commits behind head on main.

Files with missing lines Patch % Lines
...engine/src/vm/opcode/disposal/dispose_resources.rs 56.25% 7 Missing ⚠️
core/engine/src/vm/flowgraph/mod.rs 0.00% 6 Missing ⚠️
core/engine/src/bytecompiler/mod.rs 16.66% 5 Missing ⚠️
core/engine/src/vm/code_block.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #5079       +/-   ##
===========================================
+ Coverage   47.24%   59.46%   +12.21%     
===========================================
  Files         476      582      +106     
  Lines       46892    63236    +16344     
===========================================
+ Hits        22154    37603    +15449     
- Misses      24738    25633      +895

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov