Skip to content

Enable oscars behind feature flags in boa_gc #5115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nekevss wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable oscars behind feature flags in boa_gc #5115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3900f18
enables oscars in feature flagged boa_gc module
nekevss Mar 17, 2026
fa48d87
Just re-export oscars
nekevss Mar 17, 2026
2d5bddc
Remove extra flags
nekevss Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions core/gc/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ either = ["dep:either"]
# Enable default implementations of trace and finalize for the arrayvec crate
arrayvec = ["dep:arrayvec"]

oscars = ["dep:oscars", "unstable"]

# Unstable feature
unstable = []
Comment on lines +27 to +28
Copy link
Member

@jedel1043 jedel1043 Mar 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the unstable feature? Is it not enough to have the oscars feature to gate the new GC?


[dependencies]
boa_macros.workspace = true
hashbrown.workspace = true
Expand All @@ -31,6 +36,8 @@ either = { workspace = true, optional = true }
thin-vec = { workspace = true, optional = true }
icu_locale_core = { workspace = true, optional = true }
arrayvec = { workspace = true, optional = true }
oscars = { git = "https://github.com/boa-dev/oscars.git", rev = "d4864e7", optional = true }


[lints]
workspace = true
Expand Down
3 changes: 3 additions & 0 deletions core/gc/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@

extern crate self as boa_gc;

#[cfg(feature = "oscars")]
pub use oscars;

mod cell;
mod pointers;
mod trace;
Expand Down
Loading