Skip to content

docs(engine): add spec references for bytecode internals#5147

Open
Xavrir wants to merge 1 commit intoboa-dev:mainfrom
Xavrir:docs/spec-references-2426
Open

docs(engine): add spec references for bytecode internals#5147
Xavrir wants to merge 1 commit intoboa-dev:mainfrom
Xavrir:docs/spec-references-2426

Conversation

@Xavrir
Copy link
Contributor

@Xavrir Xavrir commented Mar 19, 2026

Summary

  • add module-level spec references for the bytecompiler and opcode layers
  • document how spec ! operations map to Boa's internal bytecode invariants
  • clarify operand decoding assumptions in the opcode argument helpers

Testing

  • cargo fmt --all --check
  • cargo check -p boa_engine --all-features
  • pre-push cargo make run-ci

Closes #2426

@Xavrir Xavrir requested a review from a team as a code owner March 19, 2026 04:09
@github-actions github-actions bot added Waiting On Review Waiting on reviews from the maintainers C-Builtins PRs and Issues related to builtins/intrinsics C-VM Issues and PRs related to the Boa Virtual Machine. labels Mar 19, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 19, 2026
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,073 50,073 0
Ignored 2,072 2,072 0
Failed 818 818 0
Panics 0 0 0
Conformance 94.54% 94.54% 0.00%

Tested main commit: 055ee0958ce332f3f99af27536a7c6f9a91def27
Tested PR commit: 15b421b555a4a9f92c4ce96417414d78ef49f67f
Compare commits: 055ee09...15b421b

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.51%. Comparing base (6ddc2b4) to head (15b421b).
⚠️ Report is 890 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5147       +/-   ##
===========================================
+ Coverage   47.24%   59.51%   +12.27%     
===========================================
  Files         476      580      +104     
  Lines       46892    63181    +16289     
===========================================
+ Hits        22154    37602    +15448     
- Misses      24738    25579      +841     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-VM Issues and PRs related to the Boa Virtual Machine. Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document opcode and bytecompiler spec references

1 participant