refactor(engine): encapsulate Context VM field access behind wrapper methods#5149
Open
hansl wants to merge 1 commit intoboa-dev:mainfrom
Open
refactor(engine): encapsulate Context VM field access behind wrapper methods#5149hansl wants to merge 1 commit intoboa-dev:mainfrom
hansl wants to merge 1 commit intoboa-dev:mainfrom
Conversation
…methods Add `context/vm_access.rs` with 45 wrapper methods that delegate to `Context`'s internal `Vm` field, then replace all ~600 direct `context.vm.*` accesses across 78 files with calls to these wrappers. This is the first step toward extracting Context into its own crate (boa_context). By routing all external access through methods, the internal structure of Context can be changed without touching call sites. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5149 +/- ##
===========================================
+ Coverage 47.24% 59.61% +12.36%
===========================================
Files 476 581 +105
Lines 46892 63218 +16326
===========================================
+ Hits 22154 37685 +15531
- Misses 24738 25533 +795 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
context/vm_access.rswith 45 wrapper methods that delegate toContext's internalVmfield, then replace all ~600 directcontext.vm.*accesses across 78 files with calls to these wrappers.This is the first step toward extracting Context into its own crate (boa_context). By routing all external access through methods, the internal structure of Context can be changed without touching call sites.