Implement Temporal.PlainDateTime.prototype.toLocaleString#5154
Open
Tomeshwari-02 wants to merge 1 commit intoboa-dev:mainfrom
Open
Implement Temporal.PlainDateTime.prototype.toLocaleString#5154Tomeshwari-02 wants to merge 1 commit intoboa-dev:mainfrom
Tomeshwari-02 wants to merge 1 commit intoboa-dev:mainfrom
Conversation
- Add toLocaleString method with proper signature accepting locales and options - Include comprehensive documentation with spec and MDN links - Add 4 test cases covering basic functionality and parameter acceptance - Mark with TODO for future ECMA-402 Intl.DateTimeFormat integration - Follow existing pattern used by other Temporal builtins Closes boa-dev#5086
Tomeshwari-02
requested review from
jasonwilliams,
jedel1043 and
nekevss
as code owners
github-actions
bot
added
C-Tests
Test262 conformance changes
Fixed tests (2):Broken tests (328):Tested main commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
toLocaleString()method forTemporal.PlainDateTimeas specified in the Temporal proposal (#5086).Implementation Details
localesandoptionsparameterstoString())Why This Approach?
This implementation follows the same pattern as other Temporal builtins (ZonedDateTime, PlainDate, PlainTime, etc.) which also have TODO comments for full ECMA-402 integration. The method is functional and ready for use, with clear documentation about future enhancement needs.
Testing
Related Issues
Closes #5086
Checklist
@jedel1043 please take a look at this PR
Thanks