Add tests for Temporal.PlainTime.prototype.toLocaleString#5157
Closed
Tomeshwari-02 wants to merge 1 commit intoboa-dev:mainfrom
Closed
Add tests for Temporal.PlainTime.prototype.toLocaleString#5157Tomeshwari-02 wants to merge 1 commit intoboa-dev:mainfrom
Tomeshwari-02 wants to merge 1 commit intoboa-dev:mainfrom
Conversation
- Add comprehensive test coverage for toLocaleString method - Test basic functionality and parameter acceptance - Test with different time combinations (midnight, noon, various times) - Verify locales and options parameters are accepted - Note: Implementation falls back to ISO format until ECMA-402 integration Closes #5084
github-actions
bot
added
Waiting On Review
Test262 conformance changes
Tested main commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Add test coverage for
Temporal.PlainTime.prototype.toLocaleString📌 Summary
This PR adds comprehensive test coverage for the
Temporal.PlainTime.prototype.toLocaleStringmethod to ensure correct behavior across common use cases and edge cases.✅ Changes
Added 7 test cases for
toLocaleStringCovered:
Basic functionality
Edge cases:
00:00:00)12:00:00)Multiple time combinations
Acceptance of
localesparameterAcceptance of
optionsparameter🧪 Test Details
New tests added in:
Key test cases:
pt_to_locale_string_basicpt_to_locale_string_with_midnightpt_to_locale_string_with_noonpt_to_locale_string_with_localespt_to_locale_string_with_optionspt_to_locale_string_different_times🔗 Related Issue
Closes #5084
🚀 Impact
toLocaleString