refactor: remove Collector:Allocator supertrait#54
Open
shruti2522 wants to merge 1 commit intoboa-dev:mainfrom
Open
refactor: remove Collector:Allocator supertrait#54shruti2522 wants to merge 1 commit intoboa-dev:mainfrom
shruti2522 wants to merge 1 commit intoboa-dev:mainfrom
Conversation
shruti2522
force-pushed
the
remove-supertrait
branch
from
7a24f22 to
23acfd7
Compare
nekevss
requested changes
Mar 19, 2026
| pub fn get_allocation_data<T>( | ||
| &self, | ||
| value_ref: &T, | ||
| _value_ref: &T, |
Member
There was a problem hiding this comment.
nit: remove parameter
if this is truly unused, then we should not pass in a value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
Collector:Allocatorsupertrait implementation, since we decided not go ahead with it, also added a conclusion note in coll_alloc_supertrait notes