Conversation
nekevss
force-pushed
the
duration-md-ym-to-string
branch
from
1562f63 to
f4d8517
Compare
…nthDay, and PlainYearMonth
…ainYearMonth, and PlainMonthDay
nekevss
force-pushed
the
duration-md-ym-to-string
branch
from
a535468 to
9d46d10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the remaining functionality needed for the final
to_stringmethods onDuration,PlainYearMonth, andPlainMonthDayand also implements the methods on their intended structs.There is also an early bump of the
ixdtfcrate to the git revision to begin taking advantage of recent changes.Each of these have been implemented and tested in Boa locally.
PlainYearMonth - 100%
PlainMonthDay - 100%
Duration - 100%
For reference, the 4 final failing tests in Duration that were fixed with subsequent bug fix commits to this PR were the below:
/home/nekevss/Projects/boa/test262/test/built-ins/Temporal/Duration/prototype/toString/total-of-duration-time-units-out-of-range.js: Failed/home/nekevss/Projects/boa/test262/test/built-ins/Temporal/Duration/prototype/toString/max-value.js: Failed/home/nekevss/Projects/boa/test262/test/built-ins/Temporal/Duration/prototype/toString/no-precision-loss.js: Failed/home/nekevss/Projects/boa/test262/test/built-ins/Temporal/Duration/prototype/toString/negative-components.js: Failed