Restructure project to separate core provider APIs from non-provider APIs#169
Merged
Restructure project to separate core provider APIs from non-provider APIs#169
Conversation
Member
|
I don't think we need to be as detailed but it would be nice to generate an |
jedel1043
approved these changes
Jan 22, 2025
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
Completely agree with all the changes. I just have a small typo fix and then we can merge this :)
docs/architecture.md
Outdated
| available to import from the `temporal_rs`'s root. | ||
|
|
||
| The core implementation can be made available from the root by providing | ||
| the `--no-default-feautres` flag. |
Member
There was a problem hiding this comment.
Suggested change
| the `--no-default-feautres` flag. | |
| the `--no-default-features` flag. |
This was referenced Jan 22, 2025
jedel1043
pushed a commit
that referenced
this pull request
Jan 23, 2025
This PR fixes #169 and is related to #165, and a couple of other issues / discussions that popped up after the restructure merge. This mainly restructures the codebase to remove the wrapping types and flag the non "with_provider" methods behind a non-default "compiled_data" flag. Let me know what you think!
jedel1043
added
C-enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lays out the general concept laid out in #165.
Primarily, this PR splits the core Temporal functionality that can be used by engines into the
builtins::coremodule and then builds out wrappers for nearly all of the core builtins (Currently onlyPlainYearMonthandPlainMonthDayhave not had wrappers implemented) that can be used directly from Rust in thebuiltins::nativemodule.Ideally, this provides a better experience for using the library natively from Rust (while also giving us a cleaner API to write tests with), but still allows
with_providerAPI to be used for engines and/or anyone else who wants to implement their ownTimeZoneProvider.