Merged
Conversation
Member
|
LGTM |
Member
|
I didn't know about RFC 1035, a link with more info could be added to the code as a comment, feel free to direct commit that change. Thanks again! |
Antoineio
pushed a commit
that referenced
this pull request
Mar 13, 2025
Collaborator
Author
Done in a7eef5c 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋,
I am opening this PR to resolve #5
I moved TLDs to a separate file (
tlds.go) for better maintainabilityThis refactor allowed me to update the
Domain()function to use the extractedTLDSlist dynamically instead of hardcoded valuesI also updated the
TestDomain()function to also use theTLDSlistFinally, i added a new test,
TestTLDsLength(), to validate TLD lengthsI added this test because, while researching the most commonly used TLDs, i came across RFC 1035, which states that a label must be a maximum of 63 characters. While adhering to this standard is not mandatory, but i believe it's a good practice 🤷♂️
Let me know if any adjustments are needed. 🙏